Skip to content

Commit 93ecc2b

Browse files
committed
Skip compressed file SAX test on libxml2 >= 2.15
libxml2 2.15.0 requires callers to explicitly pass XML_PARSE_UNZIP to enable decompression. Until Nokogiri adds support for this option, skip the test on affected versions. Closes #3599
1 parent 3b2f7b9 commit 93ecc2b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/xml/sax/test_parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class TestCase
7777

7878
it "parses a compressed file" do
7979
skip("libxml2 legacy support") unless Nokogiri.uses_libxml? && Nokogiri::LIBXML_ZLIB_ENABLED
80-
skip("TODO: windows libxml 2.15.1 system libraries have ZLIB_ENABLED but it's really not") if Nokogiri::VersionInfo.instance.windows? && Nokogiri::VersionInfo.instance.libxml2_using_system?
80+
skip("libxml2 >= 2.15 requires callers to pass XML_PARSE_UNZIP to enable decompression") if Nokogiri.uses_libxml?(">= 2.15.0")
8181

8282
filename = XML_FILE + ".gz"
8383
parser.parse_file(filename)

0 commit comments

Comments
 (0)