Skip to content

Commit 3cea765

Browse files
wedsonafsmb49
authored andcommitted
rust: kernel: require Send for Module implementations
BugLink: https://bugs.launchpad.net/bugs/2070337 commit 323617f649c0966ad5e741e47e27e06d3a680d8f upstream. The thread that calls the module initialisation code when a module is loaded is not guaranteed [in fact, it is unlikely] to be the same one that calls the module cleanup code on module unload, therefore, `Module` implementations must be `Send` to account for them moving from one thread to another implicitly. Signed-off-by: Wedson Almeida Filho <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Cc: [email protected] # 6.8.x: df70d04d5697: rust: phy: implement `Send` for `Registration` Cc: [email protected] Fixes: 247b365 ("rust: add `kernel` crate") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Manuel Diewald <[email protected]> Signed-off-by: Stefan Bader <[email protected]>
1 parent 5440b1b commit 3cea765

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rust/kernel/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const __LOG_PREFIX: &[u8] = b"rust_kernel\0";
6565
/// The top level entrypoint to implementing a kernel module.
6666
///
6767
/// For any teardown or cleanup operations, your type may implement [`Drop`].
68-
pub trait Module: Sized + Sync {
68+
pub trait Module: Sized + Sync + Send {
6969
/// Called at module initialization time.
7070
///
7171
/// Use this method to perform whatever setup or registration your module

0 commit comments

Comments
 (0)