Add tsan build

- use TSAN llvm/qt deps
- build catch with CATCH_CONFIG_NO_POSIX_SIGNALS to avoid TSAN false positives
- build tbb with TSAN

Author: lkeegan

.github/workflows/release.yml

@@ -43,6 +43,14 @@ jobs:
             BOOST_BOOTSTRAP_OPTIONS: "--with-toolset=clang"
             BOOST_B2_OPTIONS: "cxxflags=-fPIC"
             TBB_ENABLE_IPO: "ON"
+          - os: "ubuntu-22.04"
+            shell: "bash"
+            BOOST_INSTALL_PREFIX: "/opt/smelibs"
+            BOOST_BOOTSTRAP_OPTIONS: "--with-toolset=clang"
+            BOOST_B2_OPTIONS: "cxxflags=-fPIC"
+            TBB_ENABLE_IPO: "ON"
+            TBB_SANITIZE: "thread"
+            BUILD_TAG: "_tsan"
           - os: "ubuntu-22.04-arm"
             shell: "bash"
             BOOST_INSTALL_PREFIX: "/opt/smelibs"
@@ -77,11 +85,15 @@ jobs:
       BOOST_BOOTSTRAP_OPTIONS: ${{ matrix.BOOST_BOOTSTRAP_OPTIONS }}
       BOOST_B2_OPTIONS: ${{ matrix.BOOST_B2_OPTIONS }}
       TBB_ENABLE_IPO: ${{ matrix.TBB_ENABLE_IPO }}
+      TBB_SANITIZE: ${{ matrix.TBB_SANITIZE }}
+      BUILD_TAG: ${{ matrix.BUILD_TAG }}
     steps:
-      - uses: spatial-model-editor/[email protected].6
+      - uses: spatial-model-editor/[email protected].15
         with:
-          sme_deps_llvm: "21.1.2"
-          sme_deps_qt: "6.9.2"
+          sme_deps_llvm: "21.1.2-tsan"
+          sme_deps_qt: "6.9.2-tsan"
+          build_tag: ${{ matrix.BUILD_TAG }}
+          cache_id: ${{ matrix.BUILD_TAG }}
       - uses: actions/checkout@v4
       - run: ./build.sh
       - uses: actions/upload-artifact@v4

.pre-commit-config.yaml

@@ -11,17 +11,18 @@ repos:
       - id: mixed-line-ending
         exclude: '.*\.diff$'
   - repo: https://github.com/rhysd/actionlint
-    rev: v1.7.7
+    rev: v1.7.8
     hooks:
       - id: actionlint
   - repo: https://github.com/pecigonzalo/pre-commit-shfmt
     rev: v2.2.0
     hooks:
       - id: shell-fmt-go
   - repo: https://github.com/google/yamlfmt
-    rev: v0.17.2
+    rev: v0.18.0
     hooks:
       - id: yamlfmt
+        files: \.(yaml|yml)$
   - repo: https://github.com/cheshirekow/cmake-format-precommit
     rev: v0.6.13
     hooks:

build.sh

@@ -35,6 +35,7 @@ echo "NLOPT_VERSION: ${NLOPT_VERSION}"
 export "CMAKE_POLICY_VERSION_MINIMUM=3.5"
 
 NPROCS=4
+echo "BUILD_TAG = $BUILD_TAG"
 echo "NPROCS: ${NPROCS}"
 echo "PATH: ${PATH}"
 echo "SUDO_CMD: ${SUDO_CMD}"
@@ -158,6 +159,7 @@ ${SUDO_CMD} ninja install
 cd ../../
 
 # build static version of Catch2 library
+# build with posix signals disabled to avoid https://github.com/catchorg/Catch2/issues/1833 when using TSAN
 git clone -b $CATCH2_VERSION --depth 1 https://github.com/catchorg/Catch2.git
 cd Catch2
 mkdir build
@@ -173,6 +175,7 @@ cmake -GNinja .. \
     -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
     -DBUILD_SHARED_LIBS=OFF \
     -DCATCH_INSTALL_DOCS=OFF \
+    -DCATCH_CONFIG_NO_POSIX_SIGNALS=1 \
     -DCATCH_INSTALL_EXTRAS=ON
 time ninja
 ${SUDO_CMD} ninja install
@@ -304,9 +307,6 @@ cd ../../
 git clone -b $TBB_VERSION --depth 1 https://github.com/oneapi-src/oneTBB.git
 cd oneTBB
 # patch for "c++.exe: fatal error: input file '/dev/null' is the same as output file" issue on windows due to cmake execute_process quoting command
-# line 50 of https://github.com/uxlfoundation/oneTBB/commit/377e6c3b1719f8cc7b68f9d0939e652d7e3bf776#diff-08a9ef6921a1ae25a4447b8a4ff5740038771e549fb6f0ff69dafb35c342a8b8R5
-# instead of calling c++ to get the binutils version we get it from CMAKE_CXX_COMPILER_LINKER_VERSION
-# note: this works fine for us as we use binutils for linker and assembler, haven't checked if it also works if a different linker is used.
 git apply --ignore-space-change --ignore-whitespace --verbose ../tbb.diff
 mkdir build
 cd build
@@ -321,6 +321,7 @@ cmake -GNinja .. \
     -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
     -DTBB_ENABLE_IPO="$TBB_ENABLE_IPO" \
     -DTBB_STRICT=OFF \
+    -DTBB_SANITIZE="$TBB_SANITIZE" \
     -DTBB_TEST=OFF
 VERBOSE=1 time ninja tbb
 ${SUDO_CMD} ninja install
@@ -713,4 +714,4 @@ ccache --show-stats
 
 mkdir artefacts
 cd artefacts
-tar -zcvf sme_deps_common_${OS}.tgz $INSTALL_PREFIX/*
+tar -zcvf sme_deps_common_${OS}${BUILD_TAG}.tgz $INSTALL_PREFIX/*