Skip to content

Commit 795c31a

Browse files
committed
raise an error if both size & buffer are passed
+ raise a ValueError if both size & buffer are passed + changed ValueError raised when size and buffer are None to a TypeError
1 parent 105b96f commit 795c31a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/pa_ringbuffer.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,11 @@ def __init__(self, elementsize, size=None, buffer=None):
8585
self._ptr = self._ffi.new('PaUtilRingBuffer*')
8686
if buffer is None:
8787
if size is None:
88-
raise ValueError(
88+
raise TypeError(
8989
"size is required when buffer parameter is not specified")
9090
self._data = self._ffi.new('unsigned char[]', size * elementsize)
91+
elif size is not None:
92+
raise TypeError('exactly one of {size, buffer} is required')
9193
else:
9294
try:
9395
data = self._ffi.from_buffer(buffer)

0 commit comments

Comments
 (0)