Skip to content

Commit 13e75f7

Browse files
authored
specify iOS device and version (#234)
1 parent 2244f6e commit 13e75f7

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

ci/run-firebase-test.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ def gcloud_upload(app_platform, app_path, gcloud_storage_keyword, success_keywor
6363
'--scenario-numbers 1',
6464
'--format="json"',
6565
]
66+
67+
if app_platform == 'ios':
68+
ios_device = common.get_environment_variable(
69+
'IOS_DEVICE_AND_VERSION', 'model=iphonexs,version=12.0')
70+
cmds.append('--device ' + ios_device)
71+
6672
res = common.run_shell(cmds)
6773
gcloud_storage_url = ''
6874
for line in res.stderr.readlines():
@@ -131,7 +137,7 @@ def download_app(app_platform, engine_commit_formatted_hash):
131137
res = common.run_shell(cmds)
132138
project = res.stdout.read().decode('UTF-8')
133139

134-
# Makre sure FIREBASE_LOG_DIR is exist
140+
# Make sure FIREBASE_LOG_DIR is exist
135141
if os.path.exists(FIREBASE_LOG_DIR):
136142
os.mkdir(FIREBASE_LOG_DIR)
137143

0 commit comments

Comments
 (0)