Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Commit 2fbb7a4

Browse files
authored
Reactive components quickfix (#905)
* Update changelog to no longer say FPS is incompatible * Add define symbol to all platforms * Driveby fix for android player spawning * Fix mobile spawning on cloud as well
1 parent 6b5fd78 commit 2fbb7a4

File tree

5 files changed

+74
-7
lines changed

5 files changed

+74
-7
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
- Added a `WithTimeout(TimeSpan timeout)` method to the `RedirectedProcess` class. This allows you to set a timeout for the underlying process execution.
1818
- Added a `Improbable.Gdk.Core.Collections.Result<T, E>` struct to represent a result which can either contain a value `T` or an error `E`.
1919
- Added Scripting Define Symbol `DISABLE_REACTIVE_COMPONENTS`. Using this symbol will disable all reactive componts and systems.
20-
- Currently not compatible with the FPS Starter Project.
2120
- Added a `WorkerFlagReader` which you can subscribe and `Require`. This allows you to:
2221
- Add callbacks for changes to worker flags.
2322
- Read the value of worker flags.

cloud_launch.json

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,38 @@
3333
"worker_type": "UnityClient",
3434
"permissions": [
3535
{
36-
"all": {}
36+
"entity_query": {
37+
"allow": true,
38+
"components": [
39+
"*"
40+
]
41+
}
42+
}
43+
]
44+
},
45+
{
46+
"worker_type": "AndroidClient",
47+
"permissions": [
48+
{
49+
"entity_query": {
50+
"allow": true,
51+
"components": [
52+
"*"
53+
]
54+
}
55+
}
56+
]
57+
},
58+
{
59+
"worker_type": "iOSClient",
60+
"permissions": [
61+
{
62+
"entity_query": {
63+
"allow": true,
64+
"components": [
65+
"*"
66+
]
67+
}
3768
}
3869
]
3970
}

default_launch.json

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,38 @@
5454
"worker_type": "UnityClient",
5555
"permissions": [
5656
{
57-
"all": {}
57+
"entity_query": {
58+
"allow": true,
59+
"components": [
60+
"*"
61+
]
62+
}
63+
}
64+
]
65+
},
66+
{
67+
"worker_type": "AndroidClient",
68+
"permissions": [
69+
{
70+
"entity_query": {
71+
"allow": true,
72+
"components": [
73+
"*"
74+
]
75+
}
76+
}
77+
]
78+
},
79+
{
80+
"worker_type": "iOSClient",
81+
"permissions": [
82+
{
83+
"entity_query": {
84+
"allow": true,
85+
"components": [
86+
"*"
87+
]
88+
}
5889
}
5990
]
6091
}

workers/unity/Packages/com.improbable.gdk.playerlifecycle/Systems/PlayerCreation/SendCreatePlayerRequestSystem.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ private void HandleEntityQueryResponses()
8484
++playerCreatorQueryRetries;
8585

8686
logDispatcher.HandleLog(LogType.Warning, new LogEvent(
87-
$"Retrying player creator query, attempt {playerCreatorQueryRetries}."
87+
$"Retrying player creator query, attempt {playerCreatorQueryRetries}.\n{response.Message}"
8888
));
8989

9090
SendPlayerCreatorEntityQuery();

workers/unity/ProjectSettings/ProjectSettings.asset

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,11 @@ PlayerSettings:
106106
xboxOneDisableEsram: 0
107107
xboxOnePresentImmediateThreshold: 0
108108
switchQueueCommandMemory: 0
109+
switchQueueControlMemory: 16384
110+
switchQueueComputeMemory: 262144
111+
switchNVNShaderPoolsGranularity: 33554432
112+
switchNVNDefaultPoolsGranularity: 16777216
113+
switchNVNOtherPoolsGranularity: 16777216
109114
vulkanEnableSetSRGBWrite: 0
110115
m_SupportedAspectRatios:
111116
4:3: 1
@@ -492,6 +497,7 @@ PlayerSettings:
492497
switchAllowsRuntimeAddOnContentInstall: 0
493498
switchDataLossConfirmation: 0
494499
switchUserAccountLockEnabled: 0
500+
switchSystemResourceMemory: 16777216
495501
switchSupportedNpadStyles: 3
496502
switchNativeFsCacheSize: 32
497503
switchIsHoldTypeHorizontal: 0
@@ -593,9 +599,9 @@ PlayerSettings:
593599
webGLLinkerTarget: 0
594600
webGLThreadsSupport: 0
595601
scriptingDefineSymbols:
596-
1: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP
597-
4: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP
598-
7: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP
602+
1: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP;DISABLE_REACTIVE_COMPONENTS
603+
4: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP;DISABLE_REACTIVE_COMPONENTS
604+
7: UNITY_POST_PROCESSING_STACK_V2;UNITY_DISABLE_AUTOMATIC_SYSTEM_BOOTSTRAP;DISABLE_REACTIVE_COMPONENTS
599605
13: UNITY_POST_PROCESSING_STACK_V2
600606
14: UNITY_POST_PROCESSING_STACK_V2
601607
17: UNITY_POST_PROCESSING_STACK_V2

0 commit comments

Comments
 (0)