Early out when cleaning sometimes (#475)

samiwh · web-flow · commit 435874facce0 · 2018-10-09T18:47:31.000+01:00
Early out no authority or updates to clean
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveBlittableSingularTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveBlittableSingularTranslation.cs
@@ -338,6 +338,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ExhaustiveBlittableSingular.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -355,6 +360,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ExhaustiveBlittableSingular.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveMapKeyTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveMapKeyTranslation.cs
@@ -376,6 +376,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ExhaustiveMapKey.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -393,6 +398,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ExhaustiveMapKey.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveMapValueTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveMapValueTranslation.cs
@@ -376,6 +376,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ExhaustiveMapValue.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -393,6 +398,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ExhaustiveMapValue.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveOptionalTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveOptionalTranslation.cs
@@ -376,6 +376,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ExhaustiveOptional.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -393,6 +398,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ExhaustiveOptional.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveRepeatedTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveRepeatedTranslation.cs
@@ -376,6 +376,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ExhaustiveRepeated.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -393,6 +398,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ExhaustiveRepeated.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveSingularTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveSingularTranslation.cs
@@ -346,6 +346,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ExhaustiveSingular.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -363,6 +368,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ExhaustiveSingular.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/NestedComponentTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/NestedComponentTranslation.cs
@@ -324,6 +324,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.NestedComponent.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -341,6 +346,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.NestedComponent.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/alternateschemasyntax/ConnectionTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/alternateschemasyntax/ConnectionTranslation.cs
@@ -387,6 +387,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.AlternateSchemaSyntax.Connection.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -404,6 +409,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.AlternateSchemaSyntax.Connection.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/blittabletypes/BlittableComponentTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/blittabletypes/BlittableComponentTranslation.cs
@@ -821,6 +821,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.BlittableTypes.BlittableComponent.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -838,6 +843,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.BlittableTypes.BlittableComponent.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/componentswithnofields/ComponentWithNoFieldsTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/componentswithnofields/ComponentWithNoFieldsTranslation.cs
@@ -323,6 +323,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ComponentsWithNoFields.ComponentWithNoFields.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -340,6 +345,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ComponentsWithNoFields.ComponentWithNoFields.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/componentswithnofields/ComponentWithNoFieldsWithCommandsTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/componentswithnofields/ComponentWithNoFieldsWithCommandsTranslation.cs
@@ -517,6 +517,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ComponentsWithNoFields.ComponentWithNoFieldsWithCommands.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -534,6 +539,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ComponentsWithNoFields.ComponentWithNoFieldsWithCommands.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/componentswithnofields/ComponentWithNoFieldsWithEventsTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/componentswithnofields/ComponentWithNoFieldsWithEventsTranslation.cs
@@ -387,6 +387,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.ComponentsWithNoFields.ComponentWithNoFieldsWithEvents.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -404,6 +409,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.ComponentsWithNoFields.ComponentWithNoFieldsWithEvents.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/test-project/Assets/Generated/Source/improbable/gdk/tests/nonblittabletypes/NonBlittableComponentTranslation.cs b/test-project/Assets/Generated/Source/improbable/gdk/tests/nonblittabletypes/NonBlittableComponentTranslation.cs
@@ -835,6 +835,11 @@ internal class ComponentCleanup : ComponentCleanupHandler
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<Improbable.Gdk.Tests.NonblittableTypes.NonBlittableComponent.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -852,6 +857,11 @@ public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityComman
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<Improbable.Gdk.Tests.NonblittableTypes.NonBlittableComponent.Component>>();
                 for (var i = 0; i < entities.Length; i++)
diff --git a/workers/unity/Packages/com.improbable.gdk.tools/.CodeGenerator/GdkCodeGenerator/Templates/UnityComponentConversionGenerator.tt b/workers/unity/Packages/com.improbable.gdk.tools/.CodeGenerator/GdkCodeGenerator/Templates/UnityComponentConversionGenerator.tt
@@ -677,6 +677,11 @@ for (var i = 0; i < commandDetailsList.Count; i++) {
 
             public override void CleanupUpdates(ComponentGroup updateGroup, ref EntityCommandBuffer buffer)
             {
+                if (updateGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = updateGroup.GetEntityArray();
                 var data = updateGroup.GetComponentDataArray<<#= componentNamespace #>.ReceivedUpdates>();
                 for (var i = 0; i < entities.Length; i++)
@@ -694,6 +699,11 @@ for (var i = 0; i < commandDetailsList.Count; i++) {
 
             public override void CleanupAuthChanges(ComponentGroup authorityChangeGroup, ref EntityCommandBuffer buffer)
             {
+                if (authorityChangeGroup.IsEmptyIgnoreFilter)
+                {
+                    return;
+                }
+
                 var entities = authorityChangeGroup.GetEntityArray();
                 var data = authorityChangeGroup.GetComponentDataArray<AuthorityChanges<<#= componentNamespace #>.Component>>();
                 for (var i = 0; i < entities.Length; i++)
