Subscription cleanup (#1200)

* Fix filename

* Fix folder name

* Split Callbacks.cs into separate files per class

* Remove unused EntitySubscriptions.cs
Folder rename metafiles

* AggregateSubscriptions are now made by the SubscriptionSystem

* Don't clear empty lists
Named tuples

* Formatting to style guide

* Remove GuardedAuthorityCallbackManagerSet as its a duplicated of the GuardedCallbackManagerSet

* Callback arguments are passed as ref readonly (in)

* Remove unused HashSet in WorkerFlagSubscriptionManager

* Have subscriptions use Option<T> instead of re-implementing optional values

* Changelog

Author: zeroZshadow

CHANGELOG.md

@@ -16,6 +16,13 @@
 
 - Generated Worker ID's for local development are now smaller and easier to read for debugging. [#1197](https://github.com/spatialos/gdk-for-unity/pull/1197)
 
+### Internal
+
+- Cleaned up Subscriptions and Callbacks. [#1200](https://github.com/spatialos/gdk-for-unity/pull/1200)
+  - Replaced usage of `GuardedAuthorityCallbackManagerSet` with more generic `GuardedCallbackManagerSet`.
+  - Removed unused `EntitySubscriptions` class.
+  - Formatting pass on all Subscriptions and Callbacks files.
+
 ## `0.2.10` - 2019-10-14
 
 ### Breaking Changes

workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CalllbackManagers.meta renamed to workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CallbackManagers.meta

@@ -22,7 +22,7 @@ public AuthorityConstraintCallbackManager(uint componentId, World world)
         public void InvokeCallbacks()
         {
             var changes = componentUpdateSystem.GetAuthorityChangesReceived(componentId);
-            for (int i = 0; i < changes.Count; ++i)
+            for (var i = 0; i < changes.Count; ++i)
             {
                 if (changes[i].Authority == Authority.Authoritative)
                 {
@@ -38,7 +38,7 @@ public void InvokeCallbacks()
         public void InvokeLossImminentCallbacks()
         {
             var changes = componentUpdateSystem.GetAuthorityChangesReceived(componentId);
-            for (int i = 0; i < changes.Count; ++i)
+            for (var i = 0; i < changes.Count; ++i)
             {
                 if (changes[i].Authority == Authority.AuthorityLossImminent)
                 {

workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CalllbackManagers/AuthorityConstraintCallbackManager.cs renamed to workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CallbackManagers/AuthorityConstraintCallbackManager.cs

@@ -20,7 +20,7 @@ public CommandRequestCallbackManager(World world)
         public void InvokeCallbacks()
         {
             var requests = commandSystem.GetRequests<T>();
-            for (int i = 0; i < requests.Count; ++i)
+            for (var i = 0; i < requests.Count; ++i)
             {
                 ref readonly var request = ref requests[i];
                 callbacks.InvokeAll(request.GetEntityId().Id, request);

workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CalllbackManagers/AuthorityConstraintCallbackManager.cs.meta renamed to workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CallbackManagers/AuthorityConstraintCallbackManager.cs.meta

@@ -20,7 +20,7 @@ public CommandResponseCallbackManager(World world)
         public void InvokeCallbacks()
         {
             var responses = commandSystem.GetResponses<T>();
-            for (int i = 0; i < responses.Count; ++i)
+            for (var i = 0; i < responses.Count; ++i)
             {
                 ref readonly var response = ref responses[i];
                 callbacks.InvokeAll(response.GetRequestId(), response);

workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CalllbackManagers/CommandRequestCallbackManager.cs renamed to workers/unity/Packages/io.improbable.gdk.core/Subscriptions/CallbackManagers/CommandRequestCallbackManager.cs

@@ -1,6 +1,5 @@
 using System;
 using Improbable.Gdk.Core;
-using Improbable.Worker.CInterop;
 using Unity.Entities;
 
 namespace Improbable.Gdk.Subscriptions
@@ -23,9 +22,9 @@ public ComponentAddedCallbackManager(uint componentId, World world)
         public void InvokeCallbacks()
         {
             var entities = componentUpdateSystem.GetComponentsAdded(componentId);
-            for (int i = 0; i < entities.Count; ++i)
+            foreach (var entityId in entities)
             {
-                callbacks.InvokeAll(entities[i]);
+                callbacks.InvokeAll(entityId);
             }
         }