Correctly skip builds which are not marked as required (#1435)

Jamie Brynes · web-flow · commit 91f87ed45217 · 2020-07-22T11:06:28.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,10 @@
 
 - Upgrade to Worker SDK v14.7.0. [#1434](https://github.com/spatialos/gdk-for-unity/pull/1434)
 
+### Fixed
+
+- Build targets which are marked as 'Build', but not 'Required' are now properly skipped if build support is not installed. [#1435](https://github.com/spatialos/gdk-for-unity/pull/1435)
+
 ## `0.3.8` - 2020-07-20
 
 ### Breaking Changes
diff --git a/workers/unity/Packages/io.improbable.gdk.buildsystem/Configuration/BuildContext.cs b/workers/unity/Packages/io.improbable.gdk.buildsystem/Configuration/BuildContext.cs
@@ -58,7 +58,7 @@ public static List<BuildContext> GetBuildContexts(IEnumerable<string> wantedWork
                     Debug.LogWarning(
                         $"Skipping ({targetNames}) because build support is not installed in the Unity Editor and the build target is not marked as 'Required'.");
 
-                    targetConfigs.RemoveAll(t => missingTargets.Contains(t));
+                    supportedTargets.RemoveAll(t => missingTargets.Contains(t));
                 }
 
                 result.AddRange(supportedTargets.Select(targetConfig => new BuildContext

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public static List<BuildContext> GetBuildContexts(IEnumerable<string> wantedWork`
`58`	`58`	`Debug.LogWarning(`
`59`	`59`	`$"Skipping ({targetNames}) because build support is not installed in the Unity Editor and the build target is not marked as 'Required'.");`
`60`	`60`
`61`		`- targetConfigs.RemoveAll(t => missingTargets.Contains(t));`
	`61`	`+ supportedTargets.RemoveAll(t => missingTargets.Contains(t));`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`result.AddRange(supportedTargets.Select(targetConfig => new BuildContext`