Fix PlayerHeartbeatInitializationSystem (#1352)

* Fix PlayerHeartbeatInitializationSystem to filter on the SERVER component instead of the CLIENT component.
Stop using old API for adding components

* Changelog

Author: zeroZshadow

CHANGELOG.md

@@ -14,7 +14,7 @@
     - Burst is now enabled for all PC platforms.
     - Component replication will no longer attempt to replicate components the worker does not have authority over.
 
-## Added
+### Added
 
 - Added new methods to `Snapshot` utility class. [#1338](https://github.com/spatialos/gdk-for-unity/pull/1338)
     - `GetNextEntityId()` returns the next available entity ID.
@@ -23,12 +23,16 @@
     - This allows users to add undelegated components on entities.
 - Added debug names to entities shown in EntityDebugger. [#1342](https://github.com/spatialos/gdk-for-unity/pull/1342)
 
-## Changed
+### Changed
 
 - Allow headless development builds for Linux. [#1347](https://github.com/spatialos/gdk-for-unity/pull/1347)
 - Upgrade to Worker SDK v14.6.1. [#1350](https://github.com/spatialos/gdk-for-unity/pull/1350)
 
-## Internal
+### Fixed
+
+- Fix `PlayerHeartbeatInitializationSystem` to use the right components for filtering. [#1352](https://github.com/spatialos/gdk-for-unity/pull/1352)
+
+### Internal
 
 - Added component result type filters to playground QBI queries. [#1338](https://github.com/spatialos/gdk-for-unity/pull/1338)
 - Replaced `InitUISystem` with the `InitUIBehaviour` script on the `Character` prefab. [#1338](https://github.com/spatialos/gdk-for-unity/pull/1338)

workers/unity/Packages/io.improbable.gdk.playerlifecycle/Systems/PlayerHeartbeat/PlayerHeartbeatInitializationSystem.cs

@@ -1,7 +1,4 @@
-using System;
 using Improbable.Gdk.Core;
-using Improbable.Gdk.PlayerLifecycle;
-using Unity.Collections;
 using Unity.Entities;
 
 namespace Improbable.Gdk.PlayerLifecycle
@@ -11,43 +8,30 @@ namespace Improbable.Gdk.PlayerLifecycle
     [UpdateBefore(typeof(HandlePlayerHeartbeatResponseSystem))]
     public class PlayerHeartbeatInitializationSystem : ComponentSystem
     {
-        private EntityQuery initializerGroup;
+        private EntityQuery initializerQuery;
 
         protected override void OnCreate()
         {
             base.OnCreate();
 
-            var initializerQuery = new EntityQueryDesc
+            var entityQueryDesc = new EntityQueryDesc
             {
                 All = new[]
                 {
-                    ComponentType.ReadOnly<PlayerHeartbeatClient.Component>(),
+                    ComponentType.ReadOnly<PlayerHeartbeatServer.Component>(),
                 },
-                Any = Array.Empty<ComponentType>(),
                 None = new[]
                 {
                     ComponentType.ReadWrite<HeartbeatData>(),
                 },
             };
 
-            initializerGroup = GetEntityQuery(initializerQuery);
+            initializerQuery = GetEntityQuery(entityQueryDesc);
         }
 
         protected override void OnUpdate()
         {
-            var entityType = GetArchetypeChunkEntityType();
-            var chunkArray = initializerGroup.CreateArchetypeChunkArray(Allocator.TempJob);
-
-            foreach (var chunk in chunkArray)
-            {
-                var entities = chunk.GetNativeArray(entityType);
-                for (int i = 0; i < entities.Length; i++)
-                {
-                    PostUpdateCommands.AddComponent(entities[i], new HeartbeatData());
-                }
-            }
-
-            chunkArray.Dispose();
+            EntityManager.AddComponent<HeartbeatData>(initializerQuery);
         }
     }
 }