UTY-2714: Incorrect entity added/removed callback registration (#1473)

BryanJY-Wong · web-flow · commit ff684b42e5e1 · 2020-09-02T11:54:01.000+01:00
* Correct callback registration to entity removed
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@
 
 - Fixed an issue where authority changes returned by `ComponentUpdateSystem.GetAuthorityChangesReceived()` were returned in order from newest to oldest. [#1465](https://github.com/spatialos/gdk-for-unity/pull/1465)
 - Fixed a bug where the build system would throw a null reference exception if you don't have a configuration for a worker type. [#1461](https://github.com/spatialos/gdk-for-unity/pull/1461)
+- Fixed an incorrect callback registration for entity creation/removal in the `WorldCommandSender`. [#1473](https://github.com/spatialos/gdk-for-unity/pull/1462)
 
 ## `0.3.10` - 2020-08-18
 
diff --git a/workers/unity/Packages/io.improbable.gdk.core/Subscriptions/StandardSubscriptionManagers/WorldCommands.cs b/workers/unity/Packages/io.improbable.gdk.core/Subscriptions/StandardSubscriptionManagers/WorldCommands.cs
@@ -33,7 +33,7 @@ public WorldCommandSenderSubscriptionManager(World world) : base(world)
                 }
             });
 
-            constraintsSystem.RegisterEntityAddedCallback(entityId =>
+            constraintsSystem.RegisterEntityRemovedCallback(entityId =>
             {
                 if (!entityIdToSenderSubscriptions.TryGetValue(entityId, out var subscriptions))
                 {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public WorldCommandSenderSubscriptionManager(World world) : base(world)`
`33`	`33`	`}`
`34`	`34`	`});`
`35`	`35`
`36`		`- constraintsSystem.RegisterEntityAddedCallback(entityId =>`
	`36`	`+ constraintsSystem.RegisterEntityRemovedCallback(entityId =>`
`37`	`37`	`{`
`38`	`38`	`if (!entityIdToSenderSubscriptions.TryGetValue(entityId, out var subscriptions))`
`39`	`39`	`{`