Merge pull request #16 from Bu4ak/fix-division-by-zero

Fix division by zero in array_split()

Author: freekmurze

README.md

@@ -111,6 +111,7 @@ function array_split_filter(array $array, callable $callback)
  * @param array $array
  * @param int $numberOfPieces
  * @param bool $preserveKeys
+ * @throws \InvalidArgumentException
  * @return array
  */
 function array_split(array $array, $numberOfPieces = 2, $preserveKeys = false)

src/array_functions.php

@@ -111,11 +111,16 @@ function array_split_filter(array $array, callable $callback)
  * @param array $array
  * @param int   $numberOfPieces
  * @param bool  $preserveKeys
+ * @throws \InvalidArgumentException if the provided argument $numberOfPieces is lower than 1
  *
  * @return array
  */
 function array_split(array $array, $numberOfPieces = 2, $preserveKeys = false)
 {
+    if ($numberOfPieces <= 0) {
+        throw new \InvalidArgumentException('Number of pieces parameter expected to be greater than 0');
+    }
+
     if (count($array) === 0) {
         return [];
     }

tests/ArraySplitTest.php

@@ -15,6 +15,31 @@ public function it_can_handle_an_empty_array()
         $this->assertSame(array_split([]), []);
     }
 
+    /**
+     * @dataProvider argumentsProvider
+     * @test
+     */
+    public function it_throws_exception_when_second_parameter_is_lower_than_1($numberOfPieces, $mustThrow)
+    {
+        $exception = null;
+        try {
+            array_split([], $numberOfPieces);
+        } catch (\InvalidArgumentException $exception) {}
+
+        $this->assertSame($mustThrow, $exception instanceof \InvalidArgumentException);
+    }
+
+    public function argumentsProvider()
+    {
+        return [
+          [2 , false],
+          [1 , false],
+          [0 , true],
+          [-1 , true],
+          [-2 , true],
+        ];
+    }
+
     /**
      * @test
      */