Allow _value content to be numeric (#248)

Author: dimitri-koenig

README.md

@@ -92,7 +92,11 @@ $array = [
     'The survivor' => [
         '_attributes' => ['house'=>'Hogwarts'],
         '_value' => 'Harry Potter'
-    ]
+    ],
+    'Good movie' => [
+        '_attributes' => ['category' => 'Action'],
+        '_value' => 300,
+    ],
 ];
 
 $result = ArrayToXml::convert($array);
@@ -114,6 +118,7 @@ This code will result in:
     <The_survivor house="Hogwarts">
         Harry Potter
     </The_survivor>
+    <Good_movie category="Action">300</Good_movie>
 </root>
 ```
 

src/ArrayToXml.php

@@ -172,11 +172,11 @@ protected function convertElement(DOMElement $element, mixed $value): void
             if (! $sequential) {
                 if (($key === '_attributes') || ($key === '@attributes')) {
                     $this->addAttributes($element, $data);
-                } elseif ((($key === '_value') || ($key === '@value')) && is_string($data)) {
+                } elseif ((($key === '_value') || ($key === '@value')) && is_scalar($data)) {
                     $element->nodeValue = htmlspecialchars($data);
-                } elseif ((($key === '_cdata') || ($key === '@cdata')) && is_string($data)) {
+                } elseif ((($key === '_cdata') || ($key === '@cdata')) && is_scalar($data)) {
                     $element->appendChild($this->document->createCDATASection($data));
-                } elseif ((($key === '_mixed') || ($key === '@mixed')) && is_string($data)) {
+                } elseif ((($key === '_mixed') || ($key === '@mixed')) && is_scalar($data)) {
                     $fragment = $this->document->createDocumentFragment();
                     $fragment->appendXML($data);
                     $element->appendChild($fragment);

tests/ArrayToXmlTest.php

@@ -209,6 +209,12 @@
                     '_value' => 'tom & jerry',
                 ],
             ],
+            [
+                'title' => [
+                    '_attributes' => ['category' => 'Action'],
+                    '_value' => 300,
+                ],
+            ],
         ],
     ]));
 });

tests/__snapshots__/ArrayToXmlTest__it_can_handle_values_set_with_attributes_with_special_characters__1.xml

@@ -6,4 +6,7 @@
   <movie>
     <title category="Children">tom &amp; jerry</title>
   </movie>
+  <movie>
+    <title category="Action">300</title>
+  </movie>
 </root>