Merge pull request #40 from jkniest/feature/modifiable-shell

Allow to specify shell

Author: freekmurze

README.md

@@ -75,6 +75,16 @@ $containerInstance = DockerContainer::create($imageName)
     ->start();
 ```
 
+#### Custom shell
+
+If the `bash` shell is not available in your docker image, you can specify an alternative shell.
+
+```php
+$containerInstance = DockerContainer::create($imageName)
+    ->shell('sh')
+    ->start();
+```
+
 #### Naming the container
 
 You can name the container by passing the name as the second argument to the constructor.

src/DockerContainer.php

@@ -18,6 +18,8 @@ class DockerContainer
 
     public bool $privileged = false;
 
+    public string $shell = 'bash';
+
     /** @var PortMapping[] */
     public array $portMappings = [];
 
@@ -80,6 +82,13 @@ public function privileged(bool $privileged = true): self
         return $this;
     }
 
+    public function shell(string $shell): self
+    {
+        $this->shell = $shell;
+
+        return $this;
+    }
+
     public function doNotDaemonize(): self
     {
         $this->daemonize = false;
@@ -203,7 +212,8 @@ public function getExecCommand(string $dockerIdentifier, string $command): strin
             'exec',
             '--interactive',
             $dockerIdentifier,
-            'bash -',
+            $this->shell,
+            '-',
         ];
 
         return implode(' ', $execCommand);

tests/DockerContainerTest.php

@@ -183,6 +183,16 @@ public function it_can_generate_exec_command_with_remote_host()
         $this->assertEquals('echo "whoami" | docker -H ssh://username@host exec --interactive abcdefghijkl bash -', $command);
     }
 
+    /** @test */
+    public function it_can_generate_exec_command_with_custom_shell()
+    {
+        $command = $this->container
+            ->shell('sh')
+            ->getExecCommand('abcdefghijkl', 'whoami');
+
+        $this->assertEquals('echo "whoami" | docker exec --interactive abcdefghijkl sh -', $command);
+    }
+
     /** @test */
     public function it_can_generate_copy_command()
     {