Merge pull request #231 from paulrrogers/fix-incorrect-gifsicle-i-option

Drop hard-coded `-i` option from Gifsicle

Author: freekmurze

src/Optimizers/Gifsicle.php

@@ -18,7 +18,7 @@ public function getCommand(): string
         $optionString = implode(' ', $this->options);
 
         return "\"{$this->binaryPath}{$this->binaryName}\" {$optionString}"
-            .' -i '.escapeshellarg($this->imagePath)
-            .' -o '.escapeshellarg($this->imagePath);
+            .' '.escapeshellarg($this->imagePath)
+            .' --output '.escapeshellarg($this->imagePath);
     }
 }

tests/OptimizerTest.php

@@ -1,5 +1,6 @@
 <?php
 
+use Spatie\ImageOptimizer\Optimizers\Gifsicle;
 use Spatie\ImageOptimizer\Optimizers\Jpegoptim;
 
 it('can accept options via the constructor', function () {
@@ -52,3 +53,9 @@
     expect($optimizer->binaryName())
         ->toBe('jpegoptim');
 });
+
+it('does not hardcode Gifsicle interlace option', function () {
+    $optimizer = new Gifsicle();
+    $optimizer->setImagePath('my-image.gif');
+    expect($optimizer->getCommand())->toBe("\"gifsicle\"  'my-image.gif' --output 'my-image.gif'");
+});