Unable to specify destination path on runtime

[usmanibrahim74]

II was trying this solution to change the directory of backup on runtime. but this doesn't seem to work. any way we can achieve this?
#129 (comment)

there is a workaround I found which is to change the root of filesystem and setting the app name to empty string in backup.php . But I don't like it. is there any better solution?
config(['filesystems.disks.s3.root' => $tenant->id]);

return [

'backup' => [
    /*
     * The name of this application. You can use this name to monitor
     * the backups.
     */
    'name' => '',

[rubenkuipers]

@usmanibrahim74 did you find a solution so far? I'm running into the same problem, changing the backup config on runtime in the past worked, but it doesn't seem to work any more.

[inserve-paul]

@usmanibrahim74 @rubenkuipers Any ideas for a solution? I also ran into this problem after upgrading to a newer version.

[inserve-paul]

@freekmurze Are there plans to support changing the configuration runtime? To support multi-tenant environments where every tenant has it's own backup configuration.

[rubenkuipers]

@inserve-paul I've found a way by modifying some calls that load the config settings in several functions, but haven't had time to create a solid fork yet.. will let you know when I have. It would be great if this feature could be supported, I would say this is used much more often.

[inserve-paul]

@rubenkuipers Would you like to share a basic setup for this? Maybe I can help with creating a fork and submit a PR for @freekmurze

[inserve-paul]

@rubenkuipers That sounds good! Would be great if we could still make use of this package in combination with multi tenancy

[freekmurze]

@inserve-paul I'd accept a PR for this if the changes to support this are minimal.

[inserve-paul]

@rubenkuipers Would you like to share your (temporary) solution so I can look at creating a PR?

[rubenkuipers]

@inserve-paul I created a fork with optional solution. I'm not 100% sure if the Config::rebind() call is really needed (I discovered this call is used for testing purposes) so this needs some testing.

main...rubenkuipers:laravel-backup:main

cc @freekmurze

[inserve-paul]

@rubenkuipers Thanks! Should loading of the Config not also happen in the BackupCommand itself? Since that's where the magic happens. Or maybe add it to the BaseCommand as a method like 'loadConfiguration' ?

@freekmurze What do you think?

[inserve-paul]

@freekmurze Another approach could be to add an extra input option to the BackUpCommand, what do you think of this?

Adding this to the signature:
{--reload-config}

And this to the handle() method:

        if ($this->option('reload-config')) {
            $this->config = Config::fromArray(config('backup'));
        }

That way it isn't breaking anything and up to the user to add the extra option when calling the command.