Validation of After('some_field') in nested DataCollectionOf,

[wit3]

Hi
I have a bug trying to validate a specific rules ( After('some_field') ) in some Carbon field in DataCollection of Data.

Let me show an example:

use Spatie\LaravelData\Data;
use App\Data\ConsumptionData;
use Spatie\LaravelData\Attributes\DataCollectionOf;
use Spatie\LaravelData\DataCollection;

class WebhookData extends Data
{
    public int $internal_id;

    #[DataCollectionOf(ConsumptionData::class)]
    public ?DataCollection $consumptions;    

}

use Illuminate\Support\Carbon;
use Spatie\LaravelData\Attributes\Validation\After;
use Spatie\LaravelData\Attributes\Validation\Max;
use Spatie\LaravelData\Attributes\Validation\StringType;
use Spatie\LaravelData\Data;

class ConsumptionData extends Data
{
    public string $address;

    public Carbon $date_from;

    public Carbon $date_to; 

    public static function rules(): array
    {
        return [
            'date_from' => [
                'required',
                'date_format:Y-m-d',
            ],
            'date_to' => [
                'required',
                'date_format:Y-m-d',
                new After('date_from'),
            ],
            'address' => ['required', new StringType(), new Max(15)],         
        ];
    }

    public static function stopOnFirstFailure(): bool
    {
        return true;
    }
}

If i try to validate a json that rapresent WebhookData the validation thrown a Warning PHP message,not apply the rules and not faild the validation, it's a BUG?

$jsonString = '{
    "internal_id" : 5000,
    "consumptions": [
        {
            "address": "Rome",
            "date_from": "2022-10-01",
            "date_to": "2022-09-30"
        },
        {
            "address": "Paris",
            "date_from": "2022-09-01",
            "date_to": "2022-09-30"
        },
        {
          "address": "Milan",
          "date_from": "2022-08-01",
          "date_to": "2022-08-20"
        }
    ]
}';

$jsonData = json_decode($jsonString,true);

$validation = WebhookData::validateAndCreate($jsonData);

The warning message

PHP Warning:  DateTime::modify(): Failed to parse time string (date_from) at position 0 (d): The timezone could not be found in the database in /var/www/html/vendor/nesbot/carbon/src/Carbon/Traits/Modifiers.php on line 439
PHP Warning:  DateTime::modify(): Failed to parse time string (date_from) at position 0 (d): The timezone could not be found in the database in /var/www/html/vendor/nesbot/carbon/src/Carbon/Traits/Modifiers.php on line 439
PHP Warning:  DateTime::modify(): Failed to parse time string (date_from) at position 0 (d): The timezone could not be found in the database in /var/www/html/vendor/nesbot/carbon/src/Carbon/Traits/Modifiers.php on line 439

[rubenvanassche]

This has nothing to do with the validation, your data is not being casted correctly.

Use:

#[WithCast(DateTimeInterfaceCast::class, 'Y-m-d')]

[wit3]

i think the problem it's related to nested, and unfortunatly the last release didn't fix the problem.

My validation start with a json that contain a collection of ConsumptionData as i described in first post of this discussion
However it is curious because the validation works as expectly for all field except that After

[rubenvanassche]

Did you use data v3.1?

[wit3]

Yes

[rubenvanassche]

Could you provide me a test like I've written above which show the problem? That's a lot easier to debug.

[wit3]

#491

Check test in this PR