A long list properties are repeated in fromModel

[opcodespace]

Not sure I am doing it correctly. I am to type again in fromModel. Is this the correct way? It is tedious work if we have a long list of properties.

class MemberData extends \Spatie\LaravelData\Data
{
    public function __construct(
        public int|null|Optional $user_id,
        public int|null|Optional $id,

        public string|null|Optional $gender,
        public int|null|Optional $membership_number,

        public string|null|Optional $alternative_email,
        public string|null|Optional $app_code,
        public string|null|Optional $phone1,
        public string|null|Optional $phone2,
        public string|null|Optional $company,
        public string|null|Optional $profession,
        public string|null|Optional $shirt_size,
        public int|null|Optional $handicap,
        public string|null|Optional $job_title,
        public string|null|Optional $lead_source,
        public Carbon|null|Optional $joined_date,
        public Carbon|null|Optional $leaving_date,
        public int|null|Optional $referring_member_id,
        public string|null|Optional $status,
        public string|null|Optional $contact_type,
        public int|null|Optional $membership_id,
        public int|null|Optional $is_contact_id,
        public string|null|Optional $linkedin,
        public string|null|Optional $facebook,

        public bool|null|Optional $is_ambassador,
        public bool|null|Optional $hughsiem_meeting,

        #[WithoutValidation]
        public Lazy|UserData $user
    ) {
    }

    public static function fromModel(Member $member)
    {
        return new self(
            user_id: $member->user_id,
            id: $member->id, gender: $member->gender, membership_number: $member->membership_number,
            alternative_email: $member->alternative_email, app_code: $member->app_code, phone1: $member->phone1,
            phone2: $member->phone2, company: $member->company, profession: $member->profession,
            shirt_size: $member->shirt_size, handicap: $member->handicap, job_title: $member->job_title,
            lead_source: $member->lead_source, joined_date: $member->joined_date, leaving_date: $member->leaving_date,
            referring_member_id: $member->referring_member_id, status: $member->status,
            contact_type: $member->contact_type, membership_id: $member->membership_id,
            is_contact_id: $member->is_contact_id, linkedin: $member->linkedin, facebook: $member->linkedin,
            is_ambassador: $member->is_ambassador, hughsiem_meeting: $member->hughsiem_meeting, user: UserData::from($member->user)
        );
    }

}

[rubenvanassche]

You could try:

return new self(array_merge(...$memer->toArray(), [// Some custom mappings here]));

[opcodespace]

Thanks for your response. But PhpStorm is showing an error.

[rrrrando]

I use static for that use case:

public static function fromModel(Member $member): static
{
   return static::from(array_merge(
          $member->toArray(),
         [
              'property_needs_changes' => 'changes'
         ]
   ));
}