Data Objects having inconsitencies.

[1e4]

✏️ Describe the bug
I've been stuck on this the past few hours and unable to make any headway into solving it. I'm getting an error with a single model and getting the following

Could not create App\\Data\\UserHolidayData: the constructor requires 3 parameters, 1 given. Parameters given: id. Parameters missing: holStart, holEnd

The code that doesn't work

$holiday = UserHoliday::find(1512);
$data = UserHolidayData::from($holiday);

dump($holiday, $data);

The code that does work for another model

$stat = UserInfo::find(1512);
dump($stat, UserInfoData::from($stat));

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class UserHoliday extends Model
{
    protected $table = 'user_holiday';
    public $incrementing = false;
    public $timestamps = false;

    protected $casts = [
        'holStart' => 'int',
        'holEnd'   => 'int',
    ];

    protected $fillable = [
        'holStart',
        'holEnd',
    ];
}

<?php

namespace App\Data;

use Spatie\LaravelData\Data;

class UserHolidayData extends Data
{

    public function __construct(
        public int $id,
        public int $holStart,
        public int $holEnd,
    )
    {
    }
}

I can however get this to work by adding toArray()

$holiday = UserHoliday::find(1512);
$data = UserHolidayData::from($holiday->toArray());

I was planning on using nested Data Objects with constructor promotion so I can't call ->toArray().

I am utterly confused and stumped, I've debugged as far as I can, going so far as to looking into how DataFromArrayResolver works

The createData() in DataFromArrayResolver only return an $id property which explains the null values, but why is that only returning an ID? So back we go to ResolvedDataPipeline L42

    if (! is_array($properties)) {
        $properties = $this->transformNormalizedToArray($properties);
    }

If I dump($properties) before and after this, it returns only an ID after

That's pretty much as far as I got and still don't have an answer as to why this one particular model requires ->toArray()

I've tried to include all the information possible, if you need more please let me know.

✅ Expected behavior

I expect to not need to call ->toArray() when it should handle this model automatically.

🖥️ Versions

Laravel: 11.37.0
Laravel Data: 4.11.1
PHP:8.4

[rubenvanassche]

This doesn't look like an issue with the package, try taking a at the ModelNormalizer as a start why the property is not included