Rendering a conversion only works if the original media is also renderable

[squatto]

I have a model that has a media collection for PDFs. I've registered a simple 150x200 "thumbnail" conversion to the collection. When a PDF is added to the collection, the thumbnail is generated without any problems. However, I am unable to render the "thumbnail" conversion.

This is in my view:

@if ($media->hasGeneratedConversion('thumbnail'))
  {{ $media('thumbnail')->attributes(['class' => 'img-thumbnail bg-transparent']) }}
@endif

$media->hasGeneratedConversion('thumbnail') === true because, as I already mentioned, the conversion ran just fine:

The problem is that $media('thumbnail') returns an empty string because of the conditional in \Spatie\MediaLibrary\MediaCollections\HtmlableMedia::toHtml():

public function toHtml()
{
    if (! (new Image())->canHandleMime($this->media->mime_type)) {
        return '';
    }

    // ...
}

It is checking the mime type of the original media, not the converted media. The original media is a PDF and \Spatie\MediaLibrary\Conversions\ImageGenerators\Image only handles image mime types, so toHtml() returns an empty string.

I put together a simple example you can run to recreate it. You just need to change the IDs in the find() calls.

$files = [
    'image' => Media::find(2550), // change this to a `media.id` for an image
    'pdf'   => Media::find(2551), // change this to a `media.id` for a PDF
];

foreach ($files as $file => $media) {
    dump($file, [
        'mime_type'       => $media->mime_type,
        'can_handle_mime' => (new Image())->canHandleMime($media->mime_type),
        'thumbnail_url'   => $media->getUrl('thumbnail'),
        'thumbnail_html'  => $media->img('thumbnail')->toHtml(),
    ]);
}

Here is my output:

Note that on "pdf" there is a "thumbnail_url" value but there is not a "thumbnail_html" value.

For further confirmation, I made the conditional return the string "nope":

I can get the conversion URL and output the <img> myself, of course. I'd prefer to use the built-in way of rendering though 😉

Thanks!

[freekmurze]

Feel free to submit a PR that improves this 👍