Last folder left empty (id) when deleting when registerMediaConversions is used on Model

[marcdegagne]

Salut les cousins,

I am testing this great package and love it!

I am having an issue when deleting. In some case an empty folder is left after deletion.

This only occurs when the registerMediaConversions function applies conversions to a Model, otherwise deleting with no issues.

If a conversion is applied to a Model and conversions exists for this Model, when deleting the Model or all the Medias related to that Model, the last folder (id) to be deleted is left empty on the disk.

Not big of a thing, but multiplied overtime will leave some scrap to clean.
Did I forget something or this is a bug?

On local disk nothig particular there.
Nothing special in the configuration on the media-library.php

Filesystems

'media' => [
            'driver' => 'local',
            'root' => storage_path('app/public/media'),
            'url' => env('APP_URL').'/storage/media',
            'visibility' => 'public',
 ],

On the model:

public function registerMediaConversions(Media $media = null): void
{
        $this->addMediaConversion( "thumb" )
            ->width( 150 )
            ->height( 150 );
}

Registering collections on the model

public function registerMediaCollections(): void
{
        $this->addMediaCollection( "featured" )
            ->singleFile();

        $this->addMediaCollection( "images" );
}

Creating Model and Media testing

Route::get( "images", function () 
{

    $article = Article::create();

    $article->addMedia(storage_path( "demo/angel_02.jpg"))
        ->preservingOriginal()
        ->usingName( "Mon petit poucet 2" )
        ->toMediaCollection( "images" );

    $article->addMedia(storage_path( "demo/angel_03.jpg"))
        ->preservingOriginal()
        ->usingName( "Mon petit poucet 3" )
        ->toMediaCollection( "images" );

    $article->addMedia(storage_path( "demo/angel_01.jpg"))
        ->preservingOriginal()
        ->usingName( "Mon poucet" )
        ->toMediaCollection( "featured" );

});

Deleting Model or media related to a Model

Route::get( "delete-images", function() {

    Article::find(80)->delete();

    // OR
    /*$article = Article::find(74);

   $images = $article->getAllMedia();

   foreach( $images as $image)
   {
       $image->delete();
   }*/

});

Merci,

[PaolaRuby]

Looks like a bug