Temporary uploads not removed

[martin-ro]

I'm uploading images using a pro component and tried pruning old temporary uploads.

Let's say it's Jan. 16 00:00:00. I go into my database and change one of the Spatie\MediaLibraryPro\Models\TemporaryUpload models created_at from 2022-01-16 00:00:00 to 2022-01-10 00:00:00 or even 2021-01-16 00:00:00
and run php artisan media-library:delete-old-temporary-uploads:

Start removing old temporary uploads...
0 old temporary upload(s) deleted!

Quick double check:

Route::get('/test', function () {
    dump(Carbon::now()->subDay()->toDateTimeString());

    $old = \Spatie\MediaLibraryPro\Models\TemporaryUpload::old()->get();
    dump($old);

    $old = \Spatie\MediaLibraryPro\Models\TemporaryUpload::where('created_at', '<=', Carbon::now()->subDay()->toDateTimeString())->get();
    dump($old);

    $old = \Spatie\MediaLibraryPro\Models\TemporaryUpload::where('created_at', '<=', Carbon::now()->toDateTimeString())->get();
    dump($old);
});

"2022-01-16 08:08:11"

Illuminate\Database\Eloquent\Collection {#1130 ▼
  #items: []
  #escapeWhenCastingToString: false
}

Illuminate\Database\Eloquent\Collection {#666 ▼
  #items: []
  #escapeWhenCastingToString: false
}

Illuminate\Database\Eloquent\Collection {#1287 ▼
  #items: array:8 [▶]
  #escapeWhenCastingToString: false
}

I don't understand whats going on here? Timezone is properly set too.

[danielsimkus]

I tried to replicate but get the correct result.

\Spatie\MediaLibraryPro\Models\TemporaryUpload::old()->get();
=> Illuminate\Database\Eloquent\Collection {#5842
     all: [
       Spatie\MediaLibraryPro\Models\TemporaryUpload {#5844
         id: 1,
         session_id: "dasdadsa",
         created_at: "2021-01-19 07:23:35",
         updated_at: "2022-01-19 07:23:35",
       },
     ],
   }

I'd try enabling the query log and dumping that, it may give a clue. (and if the query looks right then I'd guess its an issue with your database/table somehow

\Illuminate\Support\Facades\DB::connection()->enableQueryLog();
dd(\Illuminate\Support\Facades\DB::getQueryLog());

[freekmurze]

I also cannot replicate this. Moving this to a discussion. Feel free to PR a failing test or fix.