Spatie\Image\Enums\Fit::from(): Argument #1 ($value) must be of type string|int, Spatie\Image\Enums\Fit given

[Martin-1182]

TypeError: Spatie\Image\Enums\Fit::from(): Argument #1 ($value) must be of type string|int, Spatie\Image\Enums\Fit given in /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/Manipulations.php:69
Stack trace:
#0 /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/Manipulations.php(69): Spatie\Image\Enums\Fit::from(Object(Spatie\Image\Enums\Fit))
#1 /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/Actions/PerformManipulationsAction.php(38): Spatie\MediaLibrary\Conversions\Manipulations->apply(Object(Spatie\Image\Image))
#2 /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/Actions/PerformConversionAction.php(30): Spatie\MediaLibrary\Conversions\Actions\PerformManipulationsAction->execute(Object(Spatie\MediaLibrary\MediaCollections\Models\Media), Object(Spatie\MediaLibrary\Conversions\Conversion), '/var/www/html/s...')
#3 /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/FileManipulator.php(71): Spatie\MediaLibrary\Conversions\Actions\PerformConversionAction->execute(Object(Spatie\MediaLibrary\Conversions\Conversion), Object(Spatie\MediaLibrary\MediaCollections\Models\Media), '/var/www/html/s...')
#4 /var/www/html/vendor/laravel/framework/src/Illuminate/Collections/Traits/EnumeratesValues.php(259): Spatie\MediaLibrary\Conversions\FileManipulator->Spatie\MediaLibrary\Conversions\{closure}(Object(Spatie\MediaLibrary\Conversions\Conversion), 0)
#5 /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/FileManipulator.php(70): Illuminate\Support\Collection->each(Object(Closure))
#6 /var/www/html/vendor/spatie/laravel-medialibrary/src/Conversions/Jobs/PerformConversionsJob.php(30): Spatie\MediaLibrary\Conversions\FileManipulator->performConversions(Object(Spatie\MediaLibrary\Conversions\ConversionCollection), Object(Spatie\MediaLibrary\MediaCollections\Models\Media), false)
#7 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob->handle(Object(Spatie\MediaLibrary\Conversions\FileManipulator))
#8 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php(41): Illuminate\Container\BoundMethod::Illuminate\Container\{closure}()
#9 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(93): Illuminate\Container\Util::unwrapIfClosure(Object(Closure))
#10 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(35): Illuminate\Container\BoundMethod::callBoundMethod(Object(Illuminate\Foundation\Application), Array, Object(Closure))
#11 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(662): Illuminate\Container\BoundMethod::call(Object(Illuminate\Foundation\Application), Array, Array, NULL)
#12 /var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(128): Illuminate\Container\Container->call(Array)
#13 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}(Object(Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob))
#14 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob))
#15 /var/www/html/vendor/laravel/framework/src/Illuminate/Bus/Dispatcher.php(132): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#16 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(124): Illuminate\Bus\Dispatcher->dispatchNow(Object(Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob), false)
#17 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\Queue\CallQueuedHandler->Illuminate\Queue\{closure}(Object(Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob))
#18 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob))
#19 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(123): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#20 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/CallQueuedHandler.php(71): Illuminate\Queue\CallQueuedHandler->dispatchThroughMiddleware(Object(Illuminate\Queue\Jobs\DatabaseJob), Object(Spatie\MediaLibrary\Conversions\Jobs\PerformConversionsJob))
#21 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Jobs/Job.php(102): Illuminate\Queue\CallQueuedHandler->call(Object(Illuminate\Queue\Jobs\DatabaseJob), Array)
#22 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(439): Illuminate\Queue\Jobs\Job->fire()
#23 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(389): Illuminate\Queue\Worker->process('database', Object(Illuminate\Queue\Jobs\DatabaseJob), Object(Illuminate\Queue\WorkerOptions))
#24 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Worker.php(176): Illuminate\Queue\Worker->runJob(Object(Illuminate\Queue\Jobs\DatabaseJob), 'database', Object(Illuminate\Queue\WorkerOptions))
#25 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(139): Illuminate\Queue\Worker->daemon('database', 'default', Object(Illuminate\Queue\WorkerOptions))
#26 /var/www/html/vendor/laravel/framework/src/Illuminate/Queue/Console/WorkCommand.php(122): Illuminate\Queue\Console\WorkCommand->runWorker('database', 'default')
#27 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): Illuminate\Queue\Console\WorkCommand->handle()
#28 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Util.php(41): Illuminate\Container\BoundMethod::Illuminate\Container\{closure}()
#29 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(93): Illuminate\Container\Util::unwrapIfClosure(Object(Closure))
#30 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(35): Illuminate\Container\BoundMethod::callBoundMethod(Object(Illuminate\Foundation\Application), Array, Object(Closure))
#31 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(662): Illuminate\Container\BoundMethod::call(Object(Illuminate\Foundation\Application), Array, Array, NULL)
#32 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(213): Illuminate\Container\Container->call(Array)
#33 /var/www/html/vendor/symfony/console/Command/Command.php(279): Illuminate\Console\Command->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Illuminate\Console\OutputStyle))
#34 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(182): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Illuminate\Console\OutputStyle))
#35 /var/www/html/vendor/symfony/console/Application.php(1047): Illuminate\Console\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#36 /var/www/html/vendor/symfony/console/Application.php(316): Symfony\Component\Console\Application->doRunCommand(Object(Illuminate\Queue\Console\WorkCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#37 /var/www/html/vendor/symfony/console/Application.php(167): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#38 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(196): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#39 /var/www/html/artisan(35): Illuminate\Foundation\Console\Kernel->handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#40 {main}

"php": "^8.3",
"spatie/laravel-medialibrary": "^11",

<?php

namespace Alfred\Assets\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Spatie\Image\Enums\Fit;
use Spatie\MediaLibrary\HasMedia;
use Spatie\MediaLibrary\InteractsWithMedia;
use Spatie\MediaLibrary\MediaCollections\Models\Media;

class Asset extends Model implements HasMedia
{
    use HasFactory,
        InteractsWithMedia;

    protected $fillable = [
        'mime_type',
    ];

    public function registerAllMediaConversions(?Media $media = null): void
    {
        $format = 'jpg';

        if ($media) {
            switch ($media->extension) {
                case 'png':
                    $format = 'png';
                    break;
                case 'webp':
                    $format = 'webp';
                    break;
                case 'jpeg':
                    $format = 'jpeg';
                    break;
                case 'gif':
                    $format = 'gif';
                    break;
                case 'bmp':
                    $format = 'bmp';
                    break;
                case 'tiff':
                    $format = 'tiff';
                    break;
            }
        }

        foreach (config('assets.sizes') as $size) {
            $this->addMediaConversion($size['slug'])
                ->fit(fit: Fit::Max, desiredWidth: $size['width'], desiredHeight: $size['height'])
                ->format($format)
                ->optimize();
        }
    }
}

[michaelstoffer]

I was getting this same error. It seems as though the Enum is broken. If you change your Fit:Max to 'max', that should allow the code to run. The Enum doesn't seem to be returning a string anymore.

[dennisvandalen]

It should not be a string. The method expects a Fit enum. This is a bug in the package

[dennisvandalen]

Looks like it's introduced here: #3584 merged into 11.5.2

The fit method accepts a Spatie\Image\Enums\Fit enum but the From of course only expects a string, so this seems to be a bug.

Perhaps it's best to check if $parameters['fit'] is already a Fit enum, or to check if it is a string?

• I've submitted a PR that should fix this behaviour: Check for enum instances when applying manipulations #3661