BUG: Cleaning orphaned directories doesn't take into account a custom PathGenerator

[Propaganistas]

Creating this here as a discussion because the Issues are currently broken (see #3808)

In CleanCommand:

• the part that cleans deprecated conversions correctly resolves the path generator
• the part that cleans orphaned directories is hardcoded to using media ids. I think it should resolve the path generator as well because when having a custom path generator this part doesn't work anymore...

laravel-medialibrary/src/MediaCollections/Commands/CleanCommand.php

Line 145 in fd90ece

$conversionPath = PathGeneratorFactory::create($media)->getPathForConversions($media);

laravel-medialibrary/src/MediaCollections/Commands/CleanCommand.php

Lines 190 to 196 in fd90ece

	$prefix = config('media-library.prefix', '');
	if ($prefix !== '') {
	$prefix = trim($prefix, '/').'/';
	}
	$mediaIds = $this->mediaRepository->allIds();

[iLegion]

I had to create my own command that changed the source code. Like this.

`
protected function deleteOrphanedDirectories(): void
{
$diskName = $this->argument('disk') ?: config('media-library.disk_name');

    if (is_null(config("filesystems.disks.{$diskName}"))) {
        throw DiskDoesNotExist::create($diskName);
    }

    $prefix = config('media-library.prefix', '');

    if ($prefix !== '') {
        $prefix = trim($prefix, '/').'/';
    }

    $media = $this->mediaRepository->all();
    $mediaPaths = collect();

    /** @var array<int, string> $directories */
    $directories = $this->fileSystem->disk($diskName)->directories($prefix);

    $media->each(function (Media $item) use ($mediaPaths) {
        $mediaPaths->push((int) PathGeneratorFactory::create($item)->getPath($item));
    });

    collect($directories)
        ->map(fn (string $directory) => str_replace($prefix, '', $directory))
        ->filter(fn (string $directory) => is_numeric($directory))
        ->reject(fn (string $directory) => $mediaPaths->contains((int) $directory))
        ->each(function (string $directory) use ($diskName, $prefix) {
            $directory = $prefix.$directory;

            if (! $this->isDryRun) {
                $this->fileSystem->disk($diskName)->deleteDirectory($directory);
            }

            if ($this->rateLimit) {
                usleep((1 / $this->rateLimit) * 1_000_000);
            }

            $this->info("Orphaned media directory `{$directory}` ".($this->isDryRun ? 'found' : 'has been removed'));
        });
}

`

But its non optimized solution, because I need to load all data with path in memory in process. Its work for projects with small count of files. I don't see any other solutions regarding this yet.