Using the same state for mulitple model/abstract state

[sfortier-sjsr]

Hi,

In my app, I have multiple forms. I have a model for each form.
They all have a similar flow with similar states :

• draft
• cancelled
• refused
• approved

I would like to be able to use the same « CancelledFormState » class for each of my forms instead of creating a class for the cancelled state of each form.

I obviously get the « ClassDoesNotExtendBaseClass » because my « CancelledFormState » extends from « AbstractState » instead of the specific state of for the form. But if I extends from the specific state for the form (TimeShiftStatusState), I won't be able to use the state (CompletedFormState) for the other forms state.

I can't use the same « AbstractState » for each form because they all have some specifics states and possible transitions.

Example of my actual structure :

abstract class TimeShiftStatusState extends AbstractState
{
    use StateHasCancel;

    public static function config(): StateConfig
    {
        return parent::config()
                     ->registerState(CancelledFormState::class)
                     ->registerState(RefusedFormState::class)
                     ->registerState(ApprovedFormState::class)
                     ->default(WaitingSuperiorVerdictTimeShiftStatusState::class)
                     ->allowTransition(
                         self::statesThatCanBeRefused()->toArray(),
                         RefusedFormState::class
                     )
                     ->allowTransition(
                         self::statesThatCanBeCancelled()->toArray(),
                         CancelledFormState::class,
                     )
                     ->allowTransition(WaitingSuperiorVerdictTimeShiftStatusState::class, WaitingServiceResponsibleVerdictTimeShiftStatusState::class)
                     ->allowTransition(WaitingServiceResponsibleVerdictTimeShiftStatusState::class, WaitingHumanResourcesVerdictTimeShiftStatusState::class)
                     ->allowTransition(WaitingHumanResourcesVerdictTimeShiftStatusState::class, ApprovedFormState::class);
    }

    public function getPotentialApprovers(): Collection
    {
        return collect();
    }

    public function allStatesClass(): Collection
    {
        return collect([
            ApprovedFormState::class,
            CancelledFormState::class,
            RefusedFormState::class,
            WaitingHumanResourcesVerdictTimeShiftStatusState::class,
            WaitingServiceResponsibleVerdictTimeShiftStatusState::class,
            WaitingSuperiorVerdictTimeShiftStatusState::class,
        ]);
    }

    public static function statesThatCanBeCancelled(): Collection
    {
        return collect([
            WaitingSuperiorVerdictTimeShiftStatusState::class,
            WaitingServiceResponsibleVerdictTimeShiftStatusState::class,
            WaitingHumanResourcesVerdictTimeShiftStatusState::class,
        ]);
    }

    public static function statesThatCanBeRefused(): Collection
    {
        return collect([
            WaitingSuperiorVerdictTimeShiftStatusState::class,
            WaitingServiceResponsibleVerdictTimeShiftStatusState::class,
            WaitingHumanResourcesVerdictTimeShiftStatusState::class,
        ]);
    }
}

class CancelledFormState extends AbstractState
{
    public static string $name = 'cancelled';

    public function formStatusDescription(): string
    {
        return 'Cancelled by the author';
    }

    public function formStatusShortName(): string
    {
        return 'Cancelled';
    }
}