When deleting a user model, the associated role and permission records aren't getting deleted

[leafling]

When I delete a user using:

$user->delete()

or

$user->forceDelete()

it doesn't delete the roles or permissions associated with the $user.

If I delete the permissions and/or roles from the $user directly through detach, prior to deleting the user, the associated permission and role records do get deleted as desired...

$user->permissions()->detach();
$user->roles()->detach();

Looking at the traits for Permissions and Roles, it looks like this should be handled automatically with $user->delete(). Here is a snippet from /spatie/laravel-permission/src/Traits/HasPermissions.php which I believe should be causing these related records to be deleted, but it isn't...

    public static function bootHasPermissions()
    {
        static::deleting(function ($model) {
            if (method_exists($model, 'isForceDeleting') && ! $model->isForceDeleting()) {
                return;
            }

            $model->permissions()->detach();
        });
    }

Am I missing something? I can certainly just detach directly prior to deleting the $user as I mentioned above, but I'd like it to work as expected and take care of the detaching automatically. Any ideas?

[erikn69]

It is working for me, make a failing test for look at

laravel-permission/tests/HasPermissionsTest.php

Lines 220 to 229 in 6a3ed62

	public function it_doesnt_detach_permissions_when_soft_deleting()
	{
	$user = SoftDeletingUser::create(['email' => '[email protected]']);
	$user->givePermissionTo(['edit-news']);
	$user->delete();
	$user = SoftDeletingUser::withTrashed()->find($user->id);
	$this->assertTrue($user->hasPermissionTo('edit-news'));
	}

Also the associated role and permission never get deleted, only detached