Delete role_has_permissions table

[Mahan-Shoghy]

Hello!
Why did you keep this table? Use model_has_permissions instead?

[erikn69]

Because roles can have permissions

[Mahan-Shoghy]

Of course! But I mean model_has_permissions is polymorphic relation and can be used for this purpose,
Why we have to create another table for this?

[erikn69]

Because me and many others use Role_has_permissions instead of model_has_permissions, maybe is better if spatie delete model_has_permission, did you see the problem? Big breaking change

[Mahan-Shoghy]

Spatie\Permission\Models\Role class use HasPermissions trait

in Spatie\Permission\Traits\HasPermissions we have permissions() that return polymorphic relation with model_has_permissions table

again in Spatie\Permission\Models\Role class we rewrite permissions() for return many to many relation

I mean, the rewrite method is extra and can be removed, because roles can have permissions with model_has_permissions table too.
my question is why role_has_permissions table exists? for more readability? or is exists to allow developers for create custom table? I want to know

[erikn69]

If you reuse the same table for those relationships, it breaks teams feature, also it would be a catastrophic breaking change for everyone

laravel-permission/database/migrations/create_permission_tables.php.stub

Lines 68 to 69 in 8a69aad

	$table->primary([$columnNames['team_foreign_key'], PermissionRegistrar::$pivotPermission, $columnNames['model_morph_key'], 'model_type'],
	'model_has_permissions_permission_model_type_primary');

Also if you have custom pivot names everything would get worse

laravel-permission/config/permission.php

Line 78 in 8a69aad

'role_pivot_key' => null, //default 'role_id',

laravel-permission/config/permission.php

Line 89 in 8a69aad

'model_morph_key' => 'model_id',

Why the desire to complicate things for everyone?

[Mahan-Shoghy]

Oh thank you for your answer. This is not to complicate things, I're just challenging to learn, and it has always been my question to know why this happened. After looking at the bouncer package and seeing the tables are not separate, I dared to ask.

Anyway, I very thank you for your answer

[erikn69]

Mark this as answered