Inconsistent methods names getRoleClass, getPermissionClass

[erikn69]

On PermissionRegistrar we have strings $permissionClass, $roleClass, and they are filled with strings from config

laravel-permission/src/PermissionRegistrar.php

Lines 22 to 26 in a769221

	/** @var string */
	protected $permissionClass;
	/** @var string */
	protected $roleClass;

laravel-permission/src/PermissionRegistrar.php

Lines 66 to 67 in a769221

	$this->permissionClass = config('permission.models.permission');
	$this->roleClass = config('permission.models.role');

But on getPermissionClass(), getRoleClass() we get an instance of the contract instead of a string from getter

laravel-permission/src/PermissionRegistrar.php

Lines 220 to 226 in a769221

	/**
	* Get an instance of the permission class.
	*/
	public function getPermissionClass(): Permission
	{
	return app($this->permissionClass);
	}

So, for the method names to be more consistent, it should be something like this

public function getPermissionClass(): string
{
    return $this->permissionClass;
}
public function getPermissionInstance(): Permission 
{
    return app(Permission::class);
}

public function getRoleClass(): string
{
    return $this->roleClass;
}
public function getRoleInstance(): Role 
{
    return app(Role::class);
}

---

Also on clearClassPermissions(), it doesn't clear $permissionClass, it clear $permissions propertie

laravel-permission/src/PermissionRegistrar.php

Lines 153 to 161 in a769221

	/**
	* Clear class permissions.
	* This is only intended to be called by the PermissionServiceProvider on boot,
	* so that long-running instances like Swoole don't keep old data in memory.
	*/
	public function clearClassPermissions()
	{
	$this->permissions = null;
	}

Ping @drbyte, @freekmurze

[erikn69]

Even worse on, HasPermissions trait we have a string $permissionClass propertie, but on getPermissionClass() package set an Permission contract instance on that propertie, same for hasRolesTrait

laravel-permission/src/Traits/HasPermissions.php

Lines 20 to 23 in a769221

	trait HasPermissions
	{
	/** @var string */
	private $permissionClass;

laravel-permission/src/Traits/HasPermissions.php

Lines 42 to 49 in a769221

	public function getPermissionClass()
	{
	if (! isset($this->permissionClass)) {
	$this->permissionClass = app(PermissionRegistrar::class)->getPermissionClass();
	}
	return $this->permissionClass;
	}

laravel-permission/src/PermissionRegistrar.php

Lines 221 to 223 in a769221

	* Get an instance of the permission class.
	*/
	public function getPermissionClass(): Permission

[drbyte]

As discussed in #2368, thanks for your work on optimizing this. In addition to being more intuitive to both read/understand and use, it will improve performance as well.