Skip to content

Commit 5c43fd2

Browse files
update changelog
1 parent 2050228 commit 5c43fd2

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ All notable changes to `laravel-query-builder` will be documented in this file
88
- sorts and field selects are not allowed by default
99
- field aliases
1010

11-
## 1.17.2 - **WIP**
11+
## 1.17.2 - 2019-04-12
1212

1313
- bugfix: replace missing `sort()` method on `QueryBuilderRequest`
1414
- bugfix: don't escape `allowedSort`s and their aliases

src/Concerns/AddsFieldsToQuery.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ public function allowedFields($fields): self
3737
public function addAllRequestedFields()
3838
{
3939
if ($this->allowedFields instanceof Collection) {
40-
// If we have allowed fields we will add them in the allowed fields method.
40+
// If we have allowed fields we will have parsed them in the allowed fields method.
41+
4142
return;
4243
}
4344

@@ -72,12 +73,8 @@ protected function getFieldsForRelatedTable(string $relation): array
7273
return ColumnNameSanitizer::sanitizeArray($fields);
7374
}
7475

75-
// TEMP: Below this point is sanitized
76-
7776
protected function getRequestedFields(): Collection
7877
{
79-
// We can't sanitize here yet because the sketchy fields might be allowed.
80-
8178
return $this->request->fields();
8279
}
8380

0 commit comments

Comments
 (0)