how add custom attributes to my own Setting Model

[muhamedRadwan]

How I can make custom attributes in Setting Model

[muhamedRadwan]

why use Spatie\LaravelSettings\Settings
not extends Illuminate\Database\Eloquent\Model ?

[muhamedRadwan]

also, do I can use spaite translate in this plugin ?

[rubenvanassche]

Hi @muhamedRadwan,

Though the package uses an eloquent model as the basis for the database repository, it just could use raw sql statements, the core of the package is the Settings class. And the model should just follow, so using things like spatie/translatable and mutator* methods isn't possible.

[muhamedRadwan]

I made a new Abstract Class Called SettingsEloquent that extends the Eloquent Model
and change in the base to workaround events
and now can a user select to work with normal Settings class or SettingsEloquent class
when he/she create his own Model

also for not repeating the code, I made a trait that has all functions and variables that used in Settings Class

and used it in settings and SettingsEloquent

and in SettingsEloquent I overriding the __get function to use getAttribute function from Illuminate\Database\Eloquent\Model

to be allowed to use getMutator and normal eloquent functions

and check all unit testing it passed

also, make a new test for check getMutator and it worked normally

can I make a pull request to check together if you have time because it first time I contribute an open-source project and I'm really exciting to give community some help

[marawanaziz]

@rubenvanassche any update ?

[rubenvanassche]

Hi @marawanaziz ,

As explained in the PR @muhamedRadwan did, I don't think this package is the correct place to implement such functionality. I've listed some alternatives here:

#81 (comment)