syncTags() with tags without types removes tags with type

[rabol]

If you sync with tags that does not have a type, then all tags with a type is removed
Post model is made for the purpose to reproduce, and looks like this:

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Spatie\Tags\HasTags;

class Post extends Model
{
    use HasFactory;
    use HasTags;

    protected $fillable = [
        'name',
    ];
}

execute the following

        $post = Post::create(['name' => 'New post']);
        
        $tag1 = Tag::findOrCreate('tag1','type1');
        $tag2 = Tag::findOrCreate('tag2','type2');
        $tag3 = Tag::findOrCreate('tag3','type3');
        $tag4 = Tag::findOrCreate('tag4','type4');
        $tag5 = Tag::findOrCreate('tag5');
        $tag6 = Tag::findOrCreate('tag6');

        $post->attachTags([$tag1, $tag2, $tag3, $tag4, $tag5, $tag6]);

        foreach (Post::Find($post->id)->tags as $t) {
            debug($t->name . ' type: ' . $t->type ?? 'no type');
        }

        debug('sync');
        $post->syncTags([$tag5, $tag6]);

        foreach (Post::Find($post->id)->tags as $t) {
            debug($t->name . ' type: ' . $t->type);
        }

after the sync, only tag5 and tag6 is attached to the model

[robertorinaldi-dev]

I tried replacing

$current = $this->tags()
            ->newPivotStatement()
            ->where('taggable_id', $this->getKey())
            ->where('taggable_type', $this->getMorphClass())
            ->when($type !== null, function ($query) use ($type) {
                $tagModel = $this->tags()->getRelated();

                return $query->join(
                    $tagModel->getTable(),
                    'taggables.tag_id',
                    '=',
                    $tagModel->getTable() . '.' . $tagModel->getKeyName()
                )
                    ->where($tagModel->getTable() . '.type', $type);
            })
            ->pluck('tag_id')
            ->all();

with

$tagModel = $this->tags()->getRelated();

$current = $this->tags()
            ->newPivotStatement()
            ->where('taggable_id', $this->getKey())
            ->where('taggable_type', $this->getMorphClass())
            ->join(
                $tagModel->getTable(),
                'taggables.tag_id',
                '=',
                $tagModel->getTable() . '.' . $tagModel->getKeyName()
            )
            ->where($tagModel->getTable() . '.type', $type)
            ->pluck('tag_id')
            ->all();

in HasTags, function syncTagIds, and it seems to be working.
This way we could use syncTagsWithType($tags) with no second argument to sync all tags without type.

[freekmurze]

Feel free to send a PR with tests that fixes the bug.

[stanbridge-wcorrea]

@freekmurze Hello, I faced this today and I have a PR for this with tests. Now I remember how to do this. Ty, will open a PR soon.

[stanbridge-wcorrea]

@freekmurze there you go #511