Change hash_equals order parameters (#221)

sylfel · web-flow · commit e71006ab5c25 · 2024-08-07T09:31:15.000+02:00
diff --git a/src/SignatureValidator/DefaultSignatureValidator.php b/src/SignatureValidator/DefaultSignatureValidator.php
@@ -24,6 +24,6 @@ public function isValid(Request $request, WebhookConfig $config): bool
 
         $computedSignature = hash_hmac('sha256', $request->getContent(), $signingSecret);
 
-        return hash_equals($signature, $computedSignature);
+        return hash_equals($computedSignature, $signature);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,6 @@ public function isValid(Request $request, WebhookConfig $config): bool`
`24`	`24`
`25`	`25`	`$computedSignature = hash_hmac('sha256', $request->getContent(), $signingSecret);`
`26`	`26`
`27`		`- return hash_equals($signature, $computedSignature);`
	`27`	`+ return hash_equals($computedSignature, $signature);`
`28`	`28`	`}`
`29`	`29`	`}`