Should the template use different version requirements for Testbench?

[einenlum]

Thanks for this great template.

I encountered a weird issue when creating a package with it, related to Github Actions.
Locally, my test would pass without issue. But in actions, two setups would fail:

• PHP 8.3, Laravel 12, prefer lowest
• PHP 8.4, Laravel 12, prefer lowest

All my tests would fail with a PHPUnit error: Test code or tested code removed error handlers other than its own.
This is related to this weird issue.

I tried everything suggested in the Github issue, but nothing worked.

You can see an example of the output here.

It took me a while to analyse the differences in failing and successful actions:

Setup	Laravel	Testbench Core	Testbench	PHPUnit	Status
8-3.L12.lowest	v12.25.0	v10.5.0	v10.2.0	12.3.5	❌ FAILED
8-4.L12.lowest	v12.25.0	v10.5.0	v10.2.0	12.3.5	❌ FAILED
8-3.L11.lowest	v11.45.2	v9.16.0	v9.13.0	12.3.5	✅ SUCCESS
8-3.L11.stable	v11.45.2	v9.16.0	v9.15.0	12.3.6	✅ SUCCESS
8-3.L12.stable	v12.26.2	v10.6.2	v10.6.0	12.3.6	✅ SUCCESS
8-4.L11.lowest	v11.45.2	v9.16.0	v9.13.0	12.3.5	✅ SUCCESS
8-4.L11.stable	v11.45.2	v9.16.0	v9.15.0	12.3.6	✅ SUCCESS
8-4.L12.stable	v12.26.2	v10.6.2	v10.6.0	12.3.6	✅ SUCCESS

Turns out the difference lies in the Laravel version (installed by the Testbench package) and the Testbench version.

What finally made my tests pass was to change the testbench version requirement in my run-tests.yml matrix (from 10.* to 10.6.*):

jobs:
  test:
    runs-on: ${{ matrix.os }}
    timeout-minutes: 5
    strategy:
      fail-fast: true
      matrix:
        os: [ubuntu-latest]
        php: [8.4, 8.3]
        laravel: [12.*, 11.*]
        stability: [prefer-lowest, prefer-stable]
        include:
          - laravel: 12.*
            # Fix the weird PHPUnit issue about exception handlers
            testbench: 10.6.*
          - laravel: 11.*
            testbench: 9.*

Not sure what's the best way to fix this, but just adding this here in case it can help someone.