Use \n instead of OS dependent PHP_EOL in tests

vhenzl · vhenzl · commit 1194bcb7539b · 2020-05-09T12:04:28.000+12:00
`json_encode` with `JSON_PRETTY_PRINT` (and all other serialisation functions) always use `\n` regardless of OS, but since `PHP_EOL` is `\r\n` on Windows, `$expected` and `$actual` never can match if `PHP_EOL` used.
diff --git a/tests/Unit/Drivers/HtmlDriverTest.php b/tests/Unit/Drivers/HtmlDriverTest.php
@@ -13,7 +13,7 @@ public function it_can_serialize_a_html_string_to_pretty_html()
     {
         $driver = new HtmlDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '<!DOCTYPE html>',
             '<html lang="en">',
             '<head></head>',
diff --git a/tests/Unit/Drivers/JsonDriverTest.php b/tests/Unit/Drivers/JsonDriverTest.php
@@ -13,7 +13,7 @@ public function it_can_serialize_a_json_string_to_pretty_json()
     {
         $driver = new JsonDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '{',
             '    "foo": "bar"',
             '}',
@@ -28,7 +28,7 @@ public function it_can_serialize_a_json_hash_to_pretty_json()
     {
         $driver = new JsonDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '{',
             '    "foo": "FOO",',
             '    "bar": "BAR",',
@@ -42,7 +42,7 @@ public function it_can_serialize_a_json_hash_to_pretty_json()
             'baz' => 'BAZ',
         ]));
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '{',
             '    "foo": "FOO",',
             '    "bar": "BAR",',
@@ -74,7 +74,7 @@ public function it_can_serialize_a_json_array_to_pretty_json()
     {
         $driver = new JsonDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '[',
             '    "foo",',
             '    "bar",',
@@ -91,7 +91,7 @@ public function it_can_serialize_a_empty_json_object_to_pretty_json()
     {
         $driver = new JsonDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '{',
             '    "foo": {',
             '        "bar": true',
diff --git a/tests/Unit/Drivers/XmlDriverTest.php b/tests/Unit/Drivers/XmlDriverTest.php
@@ -13,7 +13,7 @@ public function it_can_serialize_a_xml_string_to_pretty_xml()
     {
         $driver = new XmlDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             '<?xml version="1.0"?>',
             '<foo>',
             '  <bar>baz</bar>',
diff --git a/tests/Unit/Drivers/YamlDriverTest.php b/tests/Unit/Drivers/YamlDriverTest.php
@@ -12,7 +12,7 @@ public function it_can_serialize_a_yaml_string()
     {
         $driver = new YamlDriver();
 
-        $yamlString = implode(PHP_EOL, [
+        $yamlString = implode("\n", [
             'foo: bar',
             'baz: qux',
             '',
@@ -26,7 +26,7 @@ public function it_can_serialize_a_yaml_array()
     {
         $driver = new YamlDriver();
 
-        $expected = implode(PHP_EOL, [
+        $expected = implode("\n", [
             'foo: bar',
             'baz: qux',
             '',

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ public function it_can_serialize_a_html_string_to_pretty_html()`
`13`	`13`	`{`
`14`	`14`	`$driver = new HtmlDriver();`
`15`	`15`
`16`		`- $expected = implode(PHP_EOL, [`
	`16`	`+ $expected = implode("\n", [`
`17`	`17`	`'<!DOCTYPE html>',`
`18`	`18`	`'<html lang="en">',`
`19`	`19`	`'<head></head>',`