Merge pull request #144 from mallardduck/prevent-html-serialize-regression

freekmurze · web-flow · commit 4ee06e3a6608 · 2022-06-16T21:13:21.000+02:00
Add test to cover HTML without doctype
diff --git a/composer.json b/composer.json
@@ -23,6 +23,7 @@
         "php": "^7.3|^7.4|^8.0",
         "ext-dom": "*",
         "ext-json": "*",
+        "ext-libxml": "*",
         "composer-runtime-api": "^2.0",
         "phpunit/phpunit": "^8.3|^9.0",
         "symfony/property-access": "^4.0|^5.0|^6.0",
diff --git a/tests/Unit/Drivers/HtmlDriverTest.php b/tests/Unit/Drivers/HtmlDriverTest.php
@@ -24,7 +24,7 @@ public function it_can_serialize_a_html_string_to_pretty_html()
 
         $this->assertEquals($expected, $driver->serialize('<!doctype html><html lang="en"><head></head><body><h1>Hello, world!</h1></body></html>'));
     }
-    
+
     /** @test */
     public function test_for_issue_140()
     {
@@ -46,6 +46,22 @@ public function test_for_issue_140()
         $this->assertEquals($expected, $driver->serialize($expected));
     }
 
+    /** @test */
+    public function it_can_serialize_a_html_string_without_a_doctype()
+    {
+        $driver = new HtmlDriver();
+
+        $expected = implode("\n", [
+            '<html lang="en">',
+            '<head></head>',
+            '<body><h1>Hello, world!</h1></body>',
+            '</html>',
+            '',
+        ]);
+
+        $this->assertEquals($expected, $driver->serialize('<html lang="en"><head></head><body><h1>Hello, world!</h1></body></html>'));
+    }
+
     /** @test */
     public function it_can_only_serialize_strings()
     {
