Merge pull request #59 from kojirock5260/feature/allow_array_serialize

allow array serialize

Author: sebastiandedeyne

src/Drivers/JsonDriver.php

@@ -4,17 +4,16 @@
 
 use PHPUnit\Framework\Assert;
 use Spatie\Snapshots\Driver;
-use Spatie\Snapshots\Exceptions\CantBeSerialized;
 
 class JsonDriver implements Driver
 {
     public function serialize($data): string
     {
-        if (! is_string($data)) {
-            throw new CantBeSerialized('Only strings can be serialized to json');
+        if (is_string($data)) {
+            $data = json_decode($data, true);
         }
 
-        return json_encode(json_decode($data), JSON_PRETTY_PRINT).PHP_EOL;
+        return json_encode($data, JSON_PRETTY_PRINT).PHP_EOL;
     }
 
     public function extension(): string

tests/Unit/Drivers/JsonDriverTest.php

@@ -4,7 +4,6 @@
 
 use PHPUnit\Framework\TestCase;
 use Spatie\Snapshots\Drivers\JsonDriver;
-use Spatie\Snapshots\Exceptions\CantBeSerialized;
 
 class JsonDriverTest extends TestCase
 {
@@ -24,12 +23,65 @@ public function it_can_serialize_a_json_string_to_pretty_json()
     }
 
     /** @test */
-    public function it_can_only_serialize_strings()
+    public function it_can_serialize_a_json_hash_to_pretty_json()
     {
         $driver = new JsonDriver();
 
-        $this->expectException(CantBeSerialized::class);
+        $expected = implode(PHP_EOL, [
+            '{',
+            '    "foo": "FOO",',
+            '    "bar": "BAR",',
+            '    "baz": "BAZ"',
+            '}',
+            '',
+        ]);
+        $this->assertEquals($expected, $driver->serialize([
+            'foo' => 'FOO',
+            'bar' => 'BAR',
+            'baz' => 'BAZ',
+        ]));
+
+        $expected = implode(PHP_EOL, [
+            '{',
+            '    "foo": "FOO",',
+            '    "bar": "BAR",',
+            '    "baz": {',
+            '        "aaa": "AAA",',
+            '        "bbb": "BBB",',
+            '        "ccc": [',
+            '            "xxx",',
+            '            "yyy",',
+            '            "zzz"',
+            '        ]',
+            '    }',
+            '}',
+            '',
+        ]);
+        $this->assertEquals($expected, $driver->serialize([
+            'foo' => 'FOO',
+            'bar' => 'BAR',
+            'baz' => [
+                'aaa' => 'AAA',
+                'bbb' => 'BBB',
+                'ccc' => ['xxx', 'yyy', 'zzz'],
+            ],
+        ]));
+    }
+
+    /** @test */
+    public function it_can_serialize_a_json_array_to_pretty_json()
+    {
+        $driver = new JsonDriver();
+
+        $expected = implode(PHP_EOL, [
+            '[',
+            '    "foo",',
+            '    "bar",',
+            '    "baz"',
+            ']',
+            '',
+        ]);
 
-        $driver->serialize(['foo' => 'bar']);
+        $this->assertEquals($expected, $driver->serialize(['foo', 'bar', 'baz']));
     }
 }