-
-
Notifications
You must be signed in to change notification settings - Fork 74
Closed
Description
Related to the PR #212 we introduced the possibility to set src/Drivers/ObjectDriver.php with
'yaml_inline' => 2,
'yaml_indent' => 4,
'yaml_flags' => Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK,
However the DocBlock annotations should consider setting not all but only one key. Instead of:
/**
* @param array{
* yaml_inline: int,
* yaml_indent: int,
* yaml_flags: int
* } $yamlConfig
*/do
/**
* @param array{
* yaml_inline?: int,
* yaml_indent?: int,
* yaml_flags?: int
* } $yamlConfig
*/Otherwise static analysis like PHPStan will complain that keys are missing from the first parameter of the ObjectDriver contructor.
Sorry, had not thought of that.
Metadata
Metadata
Assignees
Labels
No labels