Cleanup

Author: rubenvanassche

composer.json

@@ -16,7 +16,7 @@
         }
     ],
     "require": {
-        "php": "^8.0",
+        "php": "^8.1",
         "nikic/php-parser": "^4.18|^5.0",
         "phpdocumentor/type-resolver": "^1.6.2",
         "symfony/process": "^5.2|^6.0|^7.0"

src/Transformers/EnumTransformer.php

@@ -73,22 +73,15 @@ protected function toEnumValue(ReflectionEnumBackedCase $case): string
     {
         $value = $case->getBackingValue();
 
-        $newValue = "";
-
-        if (! is_string($value)) {
+        if (!is_string($value)) {
             return "{$value}";
         }
 
-        for ($i = 0; $i < strlen($value); $i++) {
-            $char = $value[$i];
-
-            $newValue .= match ($char) {
-                '\\' => '\\\\',
-                '\'' => '\\\'',
-                default => $char,
-            };
-        }
+        $escaped = strtr($value, [
+            '\\' => '\\\\',
+            '\'' => '\\\'',
+        ]);
 
-        return "'" . $newValue . "'";
+        return "'{$escaped}'";
     }
 }

tests/FakeClasses/StringBackedEnumWithSingleQuotes.php

@@ -116,28 +116,32 @@
 });
 
 it('can transform a backed enum with strings with single-quotes into a enum', function () {
+    enum TestStringBackedEnumWithSingleQuotes: string
+    {
+        case NO_QUOTE = 'no quote';
+        case HAS_QUOTE = 'has quote \'';
+    }
+
     $transformer = new EnumTransformer(
         TypeScriptTransformerConfig::create()->transformToNativeEnums(true)
     );
 
     $type = $transformer->transform(
-        new ReflectionClass(StringBackedEnumWithSingleQuotes::class),
+        new ReflectionClass(TestStringBackedEnumWithSingleQuotes::class),
         'Enum'
     );
 
     assertEquals("'NO_QUOTE' = 'no quote', 'HAS_QUOTE' = 'has quote \''", $type->transformed);
     assertTrue($type->missingSymbols->isEmpty());
     assertFalse($type->isInline);
     assertEquals('enum', $type->keyword);
-});
 
-it('can transform a backed enum with strings with single-quotes into a union', function () {
     $transformer = new EnumTransformer(
         TypeScriptTransformerConfig::create()->transformToNativeEnums(false)
     );
 
     $type = $transformer->transform(
-        new ReflectionClass(StringBackedEnumWithSingleQuotes::class),
+        new ReflectionClass(TestStringBackedEnumWithSingleQuotes::class),
         'Enum'
     );