Calculate MemoryEffect

Author: spavloff

llvm/include/llvm/IR/IRBuilder.h

@@ -380,6 +380,8 @@ class IRBuilderBase {
   void setConstrainedFPCallAttr(CallBase *I) {
     I->addFnAttr(Attribute::StrictFP);
     MemoryEffects ME = MemoryEffects::inaccessibleMemOnly();
+    if (I->getAttributes().hasFnAttr(Attribute::Memory))
+      ME |= I->getAttributes().getMemoryEffects();
     auto A = Attribute::getWithMemoryEffects(getContext(), ME);
     I->addFnAttr(A);
   }

llvm/include/llvm/IR/InstrTypes.h

@@ -1158,6 +1158,8 @@ class CallBase : public Instruction {
   /// number of extra operands.
   unsigned getNumSubclassExtraOperandsDynamic() const;
 
+  MemoryEffects getMemoryEffectsForBundles() const;
+
 public:
   using Instruction::getContext;
 

llvm/lib/IR/Instructions.cpp

@@ -644,17 +644,23 @@ bool CallBase::hasFloatingPointBundles() const {
          getOperandBundle(LLVMContext::OB_fpe_except);
 }
 
+MemoryEffects CallBase::getMemoryEffectsForBundles() const {
+  MemoryEffects ME = MemoryEffects::none();
+  if (hasFloatingPointBundles())
+    ME |= MemoryEffects::inaccessibleMemOnly();
+  if (hasReadingOperandBundles())
+    ME |= MemoryEffects::readOnly();
+  if (hasClobberingOperandBundles())
+    ME |= MemoryEffects::writeOnly();
+  return ME;
+}
+
 MemoryEffects CallBase::getMemoryEffects() const {
   MemoryEffects ME = getAttributes().getMemoryEffects();
   if (auto *Fn = dyn_cast<Function>(getCalledOperand())) {
     MemoryEffects FnME = Fn->getMemoryEffects();
-    if (hasOperandBundles()) {
-      // TODO: Add a method to get memory effects for operand bundles instead.
-      if (hasReadingOperandBundles())
-        FnME |= MemoryEffects::readOnly();
-      if (hasClobberingOperandBundles())
-        FnME |= MemoryEffects::writeOnly();
-    }
+    if (hasOperandBundles())
+      FnME |= getMemoryEffectsForBundles();
     ME &= FnME;
   }
   return ME;