Skip to content

Commit e13f5ef

Browse files
committed
Change action param type to int where possible
Fixes ``` Parameter #1 $param of method MichalSpacekCz\Admin\Presenters\TalksPresenter::actionTalk() expects string, int given. ``` Training object is still just a Row so it wasn't detected by the extension because `$training->id` is just mixed.
1 parent 45373be commit e13f5ef

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

site/app/Admin/Presenters/ReviewsPresenter.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ public function actionDefault(): void
2424
}
2525

2626

27-
public function actionTraining(string $param): void
27+
public function actionTraining(int $param): void
2828
{
29-
$training = $this->trainings->getById((int)$param);
29+
$training = $this->trainings->getById($param);
3030

3131
$this->template->pageTitle = 'Ohlasy na ' . $training->name;
32-
$this->template->reviews = $this->trainingReviews->getAllReviews((int)$param);
32+
$this->template->reviews = $this->trainingReviews->getAllReviews($param);
3333
}
3434

3535
}

site/app/Admin/Presenters/TalksPresenter.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ public function renderDefault(): void
4949
}
5050

5151

52-
public function actionTalk(string $param): void
52+
public function actionTalk(int $param): void
5353
{
5454
try {
55-
$this->talk = $this->talks->getById((int)$param);
55+
$this->talk = $this->talks->getById($param);
5656
} catch (TalkDoesNotExistException $e) {
5757
throw new BadRequestException($e->getMessage(), previous: $e);
5858
}
@@ -62,10 +62,10 @@ public function actionTalk(string $param): void
6262
}
6363

6464

65-
public function actionSlides(string $param): void
65+
public function actionSlides(int $param): void
6666
{
6767
try {
68-
$this->talk = $this->talks->getById((int)$param);
68+
$this->talk = $this->talks->getById($param);
6969
$this->slides = $this->talkSlides->getSlides($this->talk->getId(), $this->talk->getFilenamesTalkId());
7070
} catch (ContentTypeException | TalkDoesNotExistException $e) {
7171
throw new BadRequestException($e->getMessage(), previous: $e);

0 commit comments

Comments
 (0)