The Dead Code Detector as part of the main PHPStan config (#333)

In #332 I have added the Dead Code Detector but it was using 2 extra config files.

Here I move the configuration to the main PHPStan config file and remove the extra configs, less mess 😅

The disadvantage is that the detector will not find the dead code in the test files but I can live with that. It makes little sense anyway I think.

Author: spaze

.gitattributes

@@ -5,8 +5,6 @@
 phpcs.xml export-ignore
 phpstan.neon export-ignore
 phpstan-attributes.php export-ignore
-phpstan-dead-code-detector.neon export-ignore
-phpstan-dead-code-detector-no-tests.neon export-ignore
 phpstan-exclude-paths.php export-ignore
 phpstan-ignore-errors.php export-ignore
 phpunit.xml export-ignore

.github/workflows/php.yml

@@ -143,34 +143,3 @@ jobs:
 
       - name: Run tests
         run: composer phpunit
-
-  dead-code-detector:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        php-version:
-          - "8.4"
-        run:
-          - composer phpstan-dead-code-detector
-          - composer phpstan-dead-code-detector-no-tests
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: "Install PHP"
-        uses: shivammathur/setup-php@v2
-        with:
-          coverage: "none"
-          php-version: "${{ matrix.php-version }}"
-
-      - name: PHP info
-        run: |
-          php -v
-          php -m
-
-      - name: Install dependencies
-        run: composer update --no-progress --no-interaction
-
-      - name: Run tests
-        run: ${{ matrix.run }}

composer.json

@@ -38,7 +38,7 @@
 		"psr-4": {"Spaze\\PHPStan\\Rules\\Disallowed\\": "src"}
 	},
 	"autoload-dev": {
-		"classmap": ["tests/src"]
+		"classmap": ["tests"]
 	},
 	"scripts": {
 		"lint": "vendor/bin/parallel-lint --colors src/ tests/",
@@ -50,8 +50,6 @@
 		"phpcs": "vendor/bin/phpcs src/ tests/",
 		"cs-fix": "vendor/bin/phpcbf src/ tests/",
 		"phpstan": "vendor/bin/phpstan --ansi analyse --configuration phpstan.neon",
-		"phpstan-dead-code-detector": "vendor/bin/phpstan --ansi analyse --configuration phpstan-dead-code-detector.neon",
-		"phpstan-dead-code-detector-no-tests": "vendor/bin/phpstan --ansi analyse --configuration phpstan-dead-code-detector-no-tests.neon",
 		"phpunit": "php -d zend.assertions=1 vendor/bin/phpunit --colors=always",
 		"test": [
 			"@lint",

phpstan.neon

@@ -19,12 +19,23 @@ parameters:
 			- tests/src
 	bootstrapFiles:
 		- phpstan-attributes.php
+	ignoreErrors:
+		-
+			identifier: shipmonk.deadMethod # Used in extension.neon
+			paths:
+				- src/DisallowedSuperglobalFactory.php
+				- src/DisallowedControlStructureFactory.php
+	shipmonkDeadCode:
+		usageExcluders:
+			tests:
+				enabled: true
 
 includes:
 	- phpstan-exclude-paths.php
 	- phpstan-ignore-errors.php
 	- vendor/phpstan/phpstan/conf/bleedingEdge.neon
 	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
+	- vendor/shipmonk/dead-code-detector/rules.neon
 	- extension.neon
 	- disallowed-dangerous-calls.neon
 	- disallowed-execution-calls.neon