Skip to content

Commit 7b25c3c

Browse files
committed
Minor updates
1 parent f23f64e commit 7b25c3c

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ dependencies and information on allocated cloud resources.
9797
Benchmarks will be rebuilt after a change in source code is detected.
9898
To enforce redeployment of code and benchmark input please use flags `--update-code`
9999
and `--update-storage`, respectively.
100+
**Note:** the cache does not support updating cloud region. If you want to deploy benchmarks
101+
to a new cloud region, then use a new cache directory.
100102

101103
### Benchmark
102104

sebs/azure/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,8 @@ def deserialize(config: dict, cache: Cache, handlers: LoggingHandlers) -> Config
317317
else:
318318
config_obj.logging.info("Using user-provided config for Azure")
319319
AzureConfig.initialize(config_obj, config)
320-
resources.set_region(config_obj.region)
321320

321+
resources.set_region(config_obj.region)
322322
return config_obj
323323

324324
"""

sebs/gcp/config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ def deserialize(config: dict, cache: Cache, handlers: LoggingHandlers) -> "Confi
188188
["region", ["gcp", "region"]], # type: ignore
189189
["project_name", ["gcp", "project_name"]], # type: ignore
190190
]
191+
# for each attribute here, check if its version is different than the one provided by
192+
# user; if yes, then update the value
191193
for config_key, keys in updated_keys:
192194

193195
old_value = getattr(config_obj, config_key)

0 commit comments

Comments
 (0)