Add default for caseInsensitive...

This fix is necessary for campatibility for implementations using the
misspelled getCaseInsensitiveId method.  Note that if you reversed the
default, new implementation will fail since they don't implement the
misspelled version.  The solution is to have default implementations for
both versions.  This could, however, cause a stack overflow if no
implementation is provided.  To avoid this, we use introspection to see
if the default is used.

Note that this changes the behavior of a missing interface from a
compile time error to a run-time error.

Author: goneall

src/main/java/org/spdx/storage/IModelStore.java

@@ -17,6 +17,7 @@
  */
 package org.spdx.storage;
 
+import java.lang.reflect.Method;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Optional;
@@ -221,15 +222,6 @@ boolean isPropertyValueAssignableTo(String objectUri, PropertyDescriptor propert
 	 */
     IdType getIdType(String objectUri);
 
-	/**
-	 * In SPDX 2.2 license refs are allowed to be matched case-insensitive.  This function will return
-	 * the case-sensitive ID (e.g. if you have LicenseRef-ABC, calling this function with licenseref-abc will return LicenseRef-ABC
-	 * @param nameSpace the nameSpace used for the ID - the URI is formed by the nameSpace + "#" + caseInsensitiveId
-	 * @param caseInsensitiveId ID - case will be ignored
-	 * @return the case-sensitive ID if it exists
-	 */
-    Optional<String> getCaseSensitiveId(String nameSpace, String caseInsensitiveId);
-
 	/**
 	 * Alias for getCaseSensitiveId
 	 * @param nameSpace the nameSpace used for the ID - the URI is formed by the nameSpace + "#" + caseInsensisitiveId
@@ -239,7 +231,38 @@ boolean isPropertyValueAssignableTo(String objectUri, PropertyDescriptor propert
 	 */
 	@Deprecated
 	default Optional<String> getCaseSensisitiveId(String nameSpace, String caseInsensisitiveId) {
-		return getCaseSensitiveId(nameSpace, caseInsensisitiveId);
+		Method[] methods = this.getClass().getMethods();
+		for (Method method:methods) {
+			if (method.getName().equals("getCaseSensitiveId")) {
+				if (method.isDefault()) {
+					throw new RuntimeException("No implementation for getCaseSensitiveId in a ModelStore implementation " + this.getClass());
+				} else {
+					return getCaseSensitiveId(nameSpace, caseInsensisitiveId);
+				}
+			}
+		}
+		throw new RuntimeException("Could not find implementation for getCaseSensitiveId in a ModelStore implementation " + this.getClass());
+	}
+
+	/**
+	 * In SPDX 2.2 license refs are allowed to be matched case-insensitive.  This function will return
+	 * the case-sensitive ID (e.g. if you have LicenseRef-ABC, calling this function with licenseref-abc will return LicenseRef-ABC
+	 * @param nameSpace the nameSpace used for the ID - the URI is formed by the nameSpace + "#" + caseInsensitiveId
+	 * @param caseInsensitiveId ID - case will be ignored
+	 * @return the case-sensitive ID if it exists
+	 */
+	default Optional<String> getCaseSensitiveId(String nameSpace, String caseInsensitiveId) {
+		Method[] methods = this.getClass().getMethods();
+		for (Method method:methods) {
+			if (method.getName().equals("getCaseSensisitiveId")) {
+				if (method.isDefault()) {
+					throw new RuntimeException("No implementation for getCaseSensitiveId in a ModelStore implementation " + this.getClass());
+				} else {
+					return getCaseSensisitiveId(nameSpace, caseInsensitiveId);
+				}
+			}
+		}
+		throw new RuntimeException("Could not find implementation for getCaseSensitiveId in a ModelStore implementation " + this.getClass());
 	}
 
 	/**