chore: ensure test code is type-checked in packages/core

disintegrator · disintegrator · commit 14a5b6fd99ca · 2026-03-06T18:33:02.000Z
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -30,8 +30,8 @@
   },
   "scripts": {
     "prepublishOnly": "pnpm run build",
-    "build": "tsc -p tsconfig.json",
-    "typecheck": "tsc -p tsconfig.json --noEmit",
+    "build": "tsc -p tsconfig.build.json",
+    "typecheck": "tsc -p tsconfig.json",
     "test": "vitest run",
     "lint": "eslint src test",
     "generate:schema": "tsx scripts/generate-schema.ts"
@@ -52,4 +52,4 @@
     "unified": "^11.0.5",
     "zod": "^4.3.6"
   }
-}
+}
diff --git a/packages/core/src/test/chunk-cache.test.ts b/packages/core/src/test/chunk-cache.test.ts
@@ -2,9 +2,9 @@ import { mkdtemp, rm } from "node:fs/promises";
 import path from "node:path";
 import os from "node:os";
 import { afterEach, beforeEach, describe, expect, it } from "vitest";
-import { computeChunkFingerprint, loadChunksFromPreviousIndex } from "../src/chunk-cache.js";
-import { buildLanceDbIndex } from "../src/lancedb.js";
-import type { Chunk, ChunkingStrategy } from "../src/types.js";
+import { computeChunkFingerprint, loadChunksFromPreviousIndex } from "../chunk-cache.js";
+import { buildLanceDbIndex } from "../lancedb.js";
+import type { Chunk, ChunkingStrategy } from "../types.js";
 
 function makeChunk(overrides: Partial<Chunk> = {}): Chunk {
   return {
diff --git a/packages/core/src/test/chunking.test.ts b/packages/core/src/test/chunking.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { buildChunks, DEFAULT_MAX_CHUNK_SIZE } from "../src/chunking.js";
+import { buildChunks, DEFAULT_MAX_CHUNK_SIZE } from "../chunking.js";
 
 describe("buildChunks", () => {
   it("creates deterministic chunk IDs and resolves duplicates", () => {
diff --git a/packages/core/src/test/cursor.test.ts b/packages/core/src/test/cursor.test.ts
@@ -1,11 +1,6 @@
 import { describe, it, expect } from "vitest";
-import {
-  encodeCursor,
-  decodeCursor,
-  encodeSearchCursor,
-  decodeSearchCursor,
-} from "../src/cursor.js";
-import type { CursorPayload } from "../src/types.js";
+import { encodeCursor, decodeCursor, encodeSearchCursor, decodeSearchCursor } from "../cursor.js";
+import type { CursorPayload } from "../types.js";
 
 describe("cursor encode/decode", () => {
   // ─── Round-trip tests ──────────────────────────────────────────
diff --git a/packages/core/src/test/dedup.test.ts b/packages/core/src/test/dedup.test.ts
@@ -1,7 +1,7 @@
 import { describe, expect, it } from "vitest";
-import { dedupKey } from "../src/search-common.js";
-import { InMemorySearchEngine } from "../src/search.js";
-import type { Chunk } from "../src/types.js";
+import { dedupKey } from "../search-common.js";
+import { InMemorySearchEngine } from "../search.js";
+import type { Chunk } from "../types.js";
 
 describe("dedupKey", () => {
   const getter = (metadata: Record<string, string>) => (key: string) => metadata[key] ?? "";
diff --git a/packages/core/src/test/embedding-cache.test.ts b/packages/core/src/test/embedding-cache.test.ts
@@ -7,9 +7,9 @@ import {
   embedChunksIncremental,
   loadCache,
   saveCache,
-} from "../src/embedding-cache.js";
-import { HashEmbeddingProvider, toEmbeddingInput } from "../src/embedding.js";
-import type { Chunk, EmbeddingConfig } from "../src/types.js";
+} from "../embedding-cache.js";
+import { HashEmbeddingProvider, toEmbeddingInput } from "../embedding.js";
+import type { Chunk, EmbeddingConfig } from "../types.js";
 
 function makeChunk(overrides: Partial<Chunk> = {}): Chunk {
   return {
diff --git a/packages/core/src/test/embedding.test.ts b/packages/core/src/test/embedding.test.ts
@@ -4,7 +4,7 @@ import {
   NoopEmbeddingProvider,
   OpenAIEmbeddingProvider,
   createEmbeddingProvider,
-} from "../src/embedding.js";
+} from "../embedding.js";
 
 afterEach(() => {
   vi.restoreAllMocks();
@@ -295,7 +295,7 @@ describe("embedding providers", () => {
     // Instead, we'll rely on the fact that the provider builds JSONL deterministically,
     // so two providers with the same config and inputs produce the same SHA.
     // We'll build the expected SHA by constructing a second provider.
-    const { sha256hex } = await import("../src/embedding.js");
+    const { sha256hex } = await import("../embedding.js");
     // Build the JSONL the provider would create (access via same logic)
     const expectedJsonl = [
       JSON.stringify({
diff --git a/packages/core/src/test/integration.test.ts b/packages/core/src/test/integration.test.ts
@@ -3,10 +3,10 @@ import { mkdtemp, rm } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
 import { afterEach, describe, expect, it } from "vitest";
-import { buildChunks } from "../src/chunking.js";
-import { buildLanceDbIndex, LanceDbSearchEngine } from "../src/lancedb.js";
-import { parseManifest, resolveFileConfig } from "../src/manifest.js";
-import type { Chunk, Manifest } from "../src/types.js";
+import { buildChunks } from "../chunking.js";
+import { buildLanceDbIndex, LanceDbSearchEngine } from "../lancedb.js";
+import { parseManifest, resolveFileConfig } from "../manifest.js";
+import type { Chunk, Manifest } from "../types.js";
 
 const FIXTURES_DIR = path.resolve(import.meta.dirname, "../../../tests/fixtures/docs");
 
diff --git a/packages/core/src/test/lancedb.test.ts b/packages/core/src/test/lancedb.test.ts
@@ -1,10 +1,10 @@
 import { mkdtemp, rm } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
-import { afterEach, describe, expect, it } from "vitest";
-import { buildLanceDbIndex, LanceDbSearchEngine } from "../src/lancedb.js";
-import type { Chunk, EmbeddingProvider } from "../src/types.js";
-import { buildChunks } from "../src/chunking.js";
+import { afterEach, describe, expect, it, assert } from "vitest";
+import { buildLanceDbIndex, LanceDbSearchEngine } from "../lancedb.js";
+import type { Chunk, EmbeddingProvider } from "../types.js";
+import { buildChunks } from "../chunking.js";
 
 const tempDirs: string[] = [];
 
@@ -234,6 +234,9 @@ describe("LanceDbSearchEngine", () => {
       async embed(): Promise<number[][]> {
         return [[0, 1, 0]];
       },
+
+      configFingerprint: "",
+      costPerMillionTokens: 0,
     };
 
     const engine = await LanceDbSearchEngine.open({
@@ -286,6 +289,8 @@ describe("LanceDbSearchEngine", () => {
       async embed(): Promise<number[][]> {
         throw new Error("provider unavailable");
       },
+      configFingerprint: "",
+      costPerMillionTokens: 0,
     };
 
     const engine = await LanceDbSearchEngine.open({
@@ -484,6 +489,7 @@ third
       metadataKeys: [],
     });
 
+    assert(chunks[1]?.chunk_id);
     const result = await engine.getDoc({
       chunk_id: chunks[1].chunk_id,
       context: -1,
@@ -554,6 +560,7 @@ Greetings friend!
       metadataKeys: [],
     });
 
+    assert(target[1]?.chunk_id);
     const result = await engine.getDoc({
       chunk_id: target[1].chunk_id,
       context: -1,
diff --git a/packages/core/src/test/manifest-schema.test.ts b/packages/core/src/test/manifest-schema.test.ts
@@ -3,7 +3,7 @@ import { resolve, dirname } from "node:path";
 import { fileURLToPath } from "node:url";
 import { describe, expect, it } from "vitest";
 import { z } from "zod";
-import { ManifestSchema } from "../src/manifest-schema.js";
+import { ManifestSchema } from "../manifest-schema.js";
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
 const schemaPath = resolve(__dirname, "../../../schemas/docs-mcp.schema.json");
diff --git a/packages/core/src/test/manifest.test.ts b/packages/core/src/test/manifest.test.ts
@@ -1,6 +1,6 @@
 import { describe, expect, it } from "vitest";
-import { mergeTaxonomyConfigs, parseManifest, resolveFileConfig } from "../src/manifest.js";
-import type { Manifest } from "../src/types.js";
+import { mergeTaxonomyConfigs, parseManifest, resolveFileConfig } from "../manifest.js";
+import type { Manifest } from "../types.js";
 
 describe("manifest resolution", () => {
   it("uses last-match wins for overrides", () => {
@@ -307,13 +307,9 @@ describe("mergeTaxonomyConfigs", () => {
 
 describe("resolveFileConfig title resolution", () => {
   it("prefers frontmatter title over H1 heading", () => {
-    const markdown = [
-      "---",
-      "title: Frontmatter Title",
-      "---",
-      "# H1 Title",
-      "Body text",
-    ].join("\n");
+    const markdown = ["---", "title: Frontmatter Title", "---", "# H1 Title", "Body text"].join(
+      "\n",
+    );
 
     const resolved = resolveFileConfig({
       relativeFilePath: "guide.md",
diff --git a/packages/core/src/test/metadata.test.ts b/packages/core/src/test/metadata.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { normalizeMetadata } from "../src/metadata.js";
+import { normalizeMetadata } from "../metadata.js";
 
 /**
  * Helper to build a minimal valid metadata object.
diff --git a/packages/core/src/test/parser.test.ts b/packages/core/src/test/parser.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { extractFirstH1 } from "../src/parser.js";
+import { extractFirstH1 } from "../parser.js";
 
 describe("extractFirstH1", () => {
   it("returns the text of the first H1 heading", () => {
diff --git a/packages/core/src/test/prompt.test.ts b/packages/core/src/test/prompt.test.ts
@@ -1,7 +1,7 @@
 import { readFile } from "node:fs/promises";
 import path from "node:path";
 import { describe, expect, it } from "vitest";
-import { parsePromptMarkdown, parsePromptTemplateYaml } from "../src/prompt.js";
+import { parsePromptMarkdown, parsePromptTemplateYaml } from "../prompt.js";
 
 const FIXTURE_PROMPT_PATH = path.resolve(
   import.meta.dirname,
diff --git a/packages/core/src/test/search.test.ts b/packages/core/src/test/search.test.ts
@@ -1,7 +1,7 @@
-import { describe, expect, it } from "vitest";
-import { DocsIndex } from "../src/search.js";
-import type { Chunk } from "../src/types.js";
-import { buildChunks } from "../src/chunking.js";
+import { describe, expect, it, assert } from "vitest";
+import { DocsIndex } from "../search.js";
+import type { Chunk } from "../types.js";
+import { buildChunks } from "../chunking.js";
 
 const baseChunks: Chunk[] = [
   {
@@ -271,6 +271,7 @@ third
     });
 
     const index = new DocsIndex(chunks);
+    assert(chunks[1]?.chunk_id);
     const result = await index.getDoc({
       chunk_id: chunks[1].chunk_id,
       context: -1,
@@ -333,6 +334,7 @@ Greetings friend!
     );
 
     const index = new DocsIndex(chunks);
+    assert(target[1]?.chunk_id);
     const result = await index.getDoc({
       chunk_id: target[1].chunk_id,
       context: -1,
diff --git a/packages/core/tsconfig.build.json b/packages/core/tsconfig.build.json
@@ -0,0 +1,7 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noEmit": false
+  },
+  "exclude": ["node_modules", "src/test/**"]
+}
