chore: upgrade golanci-lint to 2.6.1 (#808)

disintegrator · web-flow · commit 356be9e442d7 · 2025-11-11T10:09:18.000-08:00
This change updates the golanci-lint tool to version 2.6.1 and addresses
new linting issues raised by updated linters.
diff --git a/mise.toml b/mise.toml
@@ -13,7 +13,7 @@
 apko = "0.30.13"
 flyctl = "0.3.189"
 go = "1.25.3"
-golangci-lint = "2.4.0"
+golangci-lint = "2.6.1"
 gum = "0.16.0"
 jq = "1.7.1"
 melange = "0.30.6"
diff --git a/server/internal/urn/resources.go b/server/internal/urn/resources.go
@@ -281,19 +281,19 @@ func (u *Resource) validate() error {
 	}
 
 	for _, part := range parts {
-		v := part[1]
+		segment, v := part[0], part[1]
 		if v == "" {
-			u.err = fmt.Errorf("%w: empty %s", ErrInvalid, part[0])
+			u.err = fmt.Errorf("%w: empty %s", ErrInvalid, segment)
 			return u.err
 		}
 
-		if len(part[1]) > maxSegmentLength {
-			u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, part[0], maxSegmentLength, len(part[1]))
+		if len(v) > maxSegmentLength {
+			u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, segment, maxSegmentLength, len(v))
 			return u.err
 		}
 
 		if !constants.SlugPatternRE.MatchString(v) {
-			u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, part[0], part[1])
+			u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, segment, v)
 			return u.err
 		}
 	}
diff --git a/server/internal/urn/runners.go b/server/internal/urn/runners.go
@@ -173,19 +173,19 @@ func (u *FunctionRunner) validate() error {
 	}
 
 	for _, part := range parts {
-		v := part[1]
+		segment, v := part[0], part[1]
 		if v == "" {
-			u.err = fmt.Errorf("%w: empty %s", ErrInvalid, part[0])
+			u.err = fmt.Errorf("%w: empty %s", ErrInvalid, segment)
 			return u.err
 		}
 
-		if len(part[1]) > maxSegmentLength {
-			u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, part[0], maxSegmentLength, len(part[1]))
+		if len(v) > maxSegmentLength {
+			u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, segment, maxSegmentLength, len(v))
 			return u.err
 		}
 
 		if !constants.SlugPatternRE.MatchString(v) {
-			u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, part[0], part[1])
+			u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, segment, v)
 			return u.err
 		}
 	}
diff --git a/server/internal/urn/tools.go b/server/internal/urn/tools.go
@@ -167,19 +167,19 @@ func (u *Tool) validate() error {
 	}
 
 	for _, part := range parts {
-		v := part[1]
+		segment, v := part[0], part[1]
 		if v == "" {
-			u.err = fmt.Errorf("%w: empty %s", ErrInvalid, part[0])
+			u.err = fmt.Errorf("%w: empty %s", ErrInvalid, segment)
 			return u.err
 		}
 
-		if len(part[1]) > maxSegmentLength {
-			u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, part[0], maxSegmentLength, len(part[1]))
+		if len(v) > maxSegmentLength {
+			u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, segment, maxSegmentLength, len(v))
 			return u.err
 		}
 
 		if !constants.SlugPatternRE.MatchString(v) {
-			u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, part[0], part[1])
+			u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, segment, v)
 			return u.err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -281,19 +281,19 @@ func (u *Resource) validate() error {`
`281`	`281`	`}`
`282`	`282`
`283`	`283`	`for _, part := range parts {`
`284`		`- v := part[1]`
	`284`	`+ segment, v := part[0], part[1]`
`285`	`285`	`if v == "" {`
`286`		`- u.err = fmt.Errorf("%w: empty %s", ErrInvalid, part[0])`
	`286`	`+ u.err = fmt.Errorf("%w: empty %s", ErrInvalid, segment)`
`287`	`287`	`return u.err`
`288`	`288`	`}`
`289`	`289`
`290`		`- if len(part[1]) > maxSegmentLength {`
`291`		`- u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, part[0], maxSegmentLength, len(part[1]))`
	`290`	`+ if len(v) > maxSegmentLength {`
	`291`	`+ u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, segment, maxSegmentLength, len(v))`
`292`	`292`	`return u.err`
`293`	`293`	`}`
`294`	`294`
`295`	`295`	`if !constants.SlugPatternRE.MatchString(v) {`
`296`		`- u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, part[0], part[1])`
	`296`	`+ u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, segment, v)`
`297`	`297`	`return u.err`
`298`	`298`	`}`
`299`	`299`	`}`
Original file line number	Diff line number	Diff line change
`@@ -173,19 +173,19 @@ func (u *FunctionRunner) validate() error {`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`for _, part := range parts {`
`176`		`- v := part[1]`
	`176`	`+ segment, v := part[0], part[1]`
`177`	`177`	`if v == "" {`
`178`		`- u.err = fmt.Errorf("%w: empty %s", ErrInvalid, part[0])`
	`178`	`+ u.err = fmt.Errorf("%w: empty %s", ErrInvalid, segment)`
`179`	`179`	`return u.err`
`180`	`180`	`}`
`181`	`181`
`182`		`- if len(part[1]) > maxSegmentLength {`
`183`		`- u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, part[0], maxSegmentLength, len(part[1]))`
	`182`	`+ if len(v) > maxSegmentLength {`
	`183`	`+ u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, segment, maxSegmentLength, len(v))`
`184`	`184`	`return u.err`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`if !constants.SlugPatternRE.MatchString(v) {`
`188`		`- u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, part[0], part[1])`
	`188`	`+ u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, segment, v)`
`189`	`189`	`return u.err`
`190`	`190`	`}`
`191`	`191`	`}`
Original file line number	Diff line number	Diff line change
`@@ -167,19 +167,19 @@ func (u *Tool) validate() error {`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`for _, part := range parts {`
`170`		`- v := part[1]`
	`170`	`+ segment, v := part[0], part[1]`
`171`	`171`	`if v == "" {`
`172`		`- u.err = fmt.Errorf("%w: empty %s", ErrInvalid, part[0])`
	`172`	`+ u.err = fmt.Errorf("%w: empty %s", ErrInvalid, segment)`
`173`	`173`	`return u.err`
`174`	`174`	`}`
`175`	`175`
`176`		`- if len(part[1]) > maxSegmentLength {`
`177`		`- u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, part[0], maxSegmentLength, len(part[1]))`
	`176`	`+ if len(v) > maxSegmentLength {`
	`177`	`+ u.err = fmt.Errorf("%w: %s segment is too long (max %d, got %d)", ErrInvalid, segment, maxSegmentLength, len(v))`
`178`	`178`	`return u.err`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`if !constants.SlugPatternRE.MatchString(v) {`
`182`		`- u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, part[0], part[1])`
	`182`	`+ u.err = fmt.Errorf("%w: disallowed characters in %s: %q", ErrInvalid, segment, v)`
`183`	`183`	`return u.err`
`184`	`184`	`}`
`185`	`185`	`}`