Skip to content

Commit d9f4980

Browse files
adaam2simplesagar
andauthored
fix: onboarding commands are defined incorrectly (#837)
# What Various places use `npm build` rather than `npm run build` --------- Co-authored-by: Sagar Batchu <[email protected]>
1 parent dc3b0cd commit d9f4980

File tree

5 files changed

+23
-16
lines changed

5 files changed

+23
-16
lines changed

.changeset/tidy-ties-invent.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"dashboard": patch
3+
---
4+
5+
Fix onboarding steps to use `npm run` prefix

client/dashboard/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@radix-ui/react-toggle-group": "^1.1.11",
4141
"@radix-ui/react-tooltip": "^1.2.8",
4242
"@react-three/drei": "^10.0.7",
43-
"@react-three/fiber": "^9.1.2",
43+
"@react-three/fiber": "^9.4.0",
4444
"@react-three/postprocessing": "^3.0.4",
4545
"@speakeasy-api/moonshine": "1.32.5",
4646
"@tailwindcss/typography": "^0.5.16",

client/dashboard/src/pages/onboarding/Wizard.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,8 @@ const CliSetupStep = ({
432432
const [installMethod, setInstallMethod] = useState<"npm" | "pnpm">("npm");
433433
const client = useSdkClient();
434434

435+
const installCommandPrefix = installMethod === "npm" ? "npm run" : "pnpm";
436+
435437
// We explicitly don't poll to advance this step because the expected flow is that the CLI opens a new window with the next step.
436438

437439
const commands = [
@@ -454,11 +456,11 @@ const CliSetupStep = ({
454456
},
455457
{
456458
label: "Build your functions",
457-
command: `${installMethod} build`,
459+
command: `${installCommandPrefix} build`,
458460
},
459461
{
460462
label: "Push your functions to Gram",
461-
command: `${installMethod} push`,
463+
command: `${installCommandPrefix} push`,
462464
},
463465
];
464466

client/dashboard/src/pages/toolsets/sources/AddSourceDialog.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,11 @@ export function FunctionsInstructions() {
255255
},
256256
{
257257
label: "Build your functions",
258-
command: "npm build",
258+
command: "npm run build",
259259
},
260260
{
261261
label: "Deploy your functions",
262-
command: "npm push",
262+
command: "npm run push",
263263
},
264264
];
265265

pnpm-lock.yaml

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)