fix

Author: TristanSpeakEasy

.mise.toml

@@ -6,14 +6,14 @@ gotestsum = "latest"
 description = "Create VSCode symlinks for tools not automatically handled by mise-vscode"
 run = [
   "mkdir -p .vscode/mise-tools",
-  "ln -sf $(mise exec golangci-lint@2.5.0 -- which golangci-lint) .vscode/mise-tools/golangci-lint",
+  "ln -sf $(mise exec golangci-lint@2.7.2 -- which golangci-lint) .vscode/mise-tools/golangci-lint",
 ]
 
 [hooks]
 postinstall = [
   "ln -sf ./AGENTS.md ./CLAUDE.md",
   "git submodule update --init --recursive",
-  "mise exec [email protected] -- go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.5.0",
+  "mise exec [email protected] -- go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.7.2",
   "mise run setup-vscode-symlinks",
   "go install go.uber.org/nilaway/cmd/nilaway@8ad05f0",
 ]

mise-tasks/examples-check

@@ -19,7 +19,7 @@ if ! git diff --quiet openapi/README.md arazzo/README.md; then
     git diff openapi/README.md arazzo/README.md
     echo ""
     echo "💡 To fix this, run: mise run update-examples"
-    echo "   Then commit the updated README files."
+    echo "   Then stage/commit the updated README files."
     exit 1
 else
     echo "✅ All examples in README files are up to date!"

mise-tasks/lint

@@ -3,7 +3,8 @@ set -euo pipefail
 
 echo "🔍 Running linting checks..."
 
-echo "🧹 Running golangci-lint (includes go vet)..."
+GOLANGCI_VERSION=$(golangci-lint --version | grep -oP 'golangci-lint has version \K[0-9.]+' || echo "unknown")
+echo "🧹 Running golangci-lint v${GOLANGCI_VERSION} (includes go vet)..."
 golangci-lint run
 
 echo "🛡️  Running nilaway..."

openapi/operation.go

@@ -151,6 +151,7 @@ func (o *Operation) GetExtensions() *extensions.Extensions {
 }
 
 // IsDeprecated is an alias for GetDeprecated for backward compatibility.
+//
 // Deprecated: Use GetDeprecated instead for consistency with other models.
 func (o *Operation) IsDeprecated() bool {
 	return o.GetDeprecated()

openapi/reference.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 	"sync"
 
 	"github.com/speakeasy-api/openapi/internal/interfaces"
@@ -636,11 +637,13 @@ func joinReferenceChain(chain []string) string {
 		return chain[0]
 	}
 
-	result := chain[0]
+	var result strings.Builder
+	result.WriteString(chain[0])
 	for i := 1; i < len(chain); i++ {
-		result += " -> " + chain[i]
+		result.WriteString(" -> ")
+		result.WriteString(chain[i])
 	}
-	return result
+	return result.String()
 }
 
 func unmarshaler[T any, V interfaces.Validator[T], C marshaller.CoreModeler](_ *OpenAPI) func(context.Context, *yaml.Node, bool) (*Reference[T, V, C], []error, error) {

yml/config.go

@@ -187,7 +187,7 @@ func inspectData(data []byte) (OutputFormat, int, IndentationStyle) {
 }
 
 func getGlobalStringStyle(doc *yaml.Node, cfg *Config) {
-	const minSamples = 3
+	const minSamples = 5
 
 	keyStyles := make([]yaml.Style, 0, minSamples)
 	valueStyles := make([]yaml.Style, 0, minSamples)
@@ -253,7 +253,8 @@ func looksLikeNumber(s string) bool {
 	return err == nil
 }
 
-// mostCommonStyle returns the most frequently occurring style from the provided styles
+// mostCommonStyle returns the most frequently occurring style from the provided styles.
+// In case of a tie, it returns the style that appears first in the slice for deterministic behavior.
 func mostCommonStyle(styles []yaml.Style) yaml.Style {
 	if len(styles) == 0 {
 		return 0
@@ -264,10 +265,12 @@ func mostCommonStyle(styles []yaml.Style) yaml.Style {
 		counts[style]++
 	}
 
-	// Find the style with the highest count
+	// Find the style with the highest count by iterating through the original slice.
+	// This ensures deterministic results when there are ties - the first occurrence wins.
 	var maxCount int
 	var mostCommon yaml.Style
-	for style, count := range counts {
+	for _, style := range styles {
+		count := counts[style]
 		if count > maxCount {
 			maxCount = count
 			mostCommon = style