Make generated Typescript more idiomatic

Author: anuraagnalluri

src/internal/utils/contenttype.ts

@@ -0,0 +1,13 @@
+export function MatchContentType(
+  contentType: string,
+  pattern: string
+): boolean {
+  if (contentType === pattern || pattern === "*" || pattern === "*/*")
+    return true;
+  if (contentType === pattern) return true;
+  const parts: string[] = contentType.split("/");
+  if (parts.length === 2) {
+    if (`${parts[0]}/*` === pattern || `*/${parts[1]}` === pattern) return true;
+  }
+  return false;
+}

src/internal/utils/queryparams.ts

@@ -6,19 +6,24 @@ export const qpMetadataKey = "queryParam";
 
 export function GetQueryParamSerializer(
   queryParams: any
-): ParamsSerializerOptions | undefined {
-  if (queryParams == null) return undefined;
+): ParamsSerializerOptions {
+  if (queryParams == null) return { encode: FormSerializerExplode };
   const fieldNames: string[] = Object.getOwnPropertyNames(queryParams);
   fieldNames.forEach((fname) => {
     const qpAnn: string = Reflect.getMetadata(
       qpMetadataKey,
       queryParams,
       fname
     );
-    if (qpAnn == null) return;
+    if (qpAnn == null) return { encode: (params: unknown) => "" };
     const qpDecorator: ParamDecorator = ParseQueryParamDecorator(qpAnn, fname);
     if (qpDecorator == null) return;
-    if (qpDecorator.Serialization === "json") return null;
+    if (qpDecorator.Serialization === "json")
+      return {
+        encode: (params: unknown) => {
+          return JSON.stringify(params);
+        },
+      };
     else {
       switch (qpDecorator.Style) {
         case "deepObject":
@@ -43,7 +48,7 @@ export function GetQueryParamSerializer(
       }
     }
   });
-  return undefined;
+  return { encode: FormSerializerExplode };
 }
 
 function FormSerializer(params: unknown): string {

src/sdk/models/operations/deleteapi.ts

@@ -6,19 +6,10 @@ export class DeleteApiPathParams {
   ApiId: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiId: string, VersionId: string) {
-    this.ApiId = ApiId;
-    this.VersionId = VersionId;
-  }
 }
 
 export class DeleteApiRequest {
   PathParams: DeleteApiPathParams;
-
-  constructor(PathParams: DeleteApiPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class DeleteApiResponse {
@@ -27,10 +18,4 @@ export class DeleteApiResponse {
   Error?: shared.Error;
 
   StatusCode: number;
-
-  constructor(ContentType: string, StatusCode: number, Error?: shared.Error) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/deleteapiendpoint.ts

@@ -8,20 +8,10 @@ export class DeleteApiEndpointPathParams {
   ApiId: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiEndpointId: string, ApiId: string, VersionId: string) {
-    this.ApiEndpointId = ApiEndpointId;
-    this.ApiId = ApiId;
-    this.VersionId = VersionId;
-  }
 }
 
 export class DeleteApiEndpointRequest {
   PathParams: DeleteApiEndpointPathParams;
-
-  constructor(PathParams: DeleteApiEndpointPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class DeleteApiEndpointResponse {
@@ -30,10 +20,4 @@ export class DeleteApiEndpointResponse {
   Error?: shared.Error;
 
   StatusCode: number;
-
-  constructor(ContentType: string, StatusCode: number, Error?: shared.Error) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/deleteschema.ts

@@ -8,20 +8,10 @@ export class DeleteSchemaPathParams {
   RevisionId: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiId: string, RevisionId: string, VersionId: string) {
-    this.ApiId = ApiId;
-    this.RevisionId = RevisionId;
-    this.VersionId = VersionId;
-  }
 }
 
 export class DeleteSchemaRequest {
   PathParams: DeleteSchemaPathParams;
-
-  constructor(PathParams: DeleteSchemaPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class DeleteSchemaResponse {
@@ -30,10 +20,4 @@ export class DeleteSchemaResponse {
   Error?: shared.Error;
 
   StatusCode: number;
-
-  constructor(ContentType: string, StatusCode: number, Error?: shared.Error) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/deleteversionmetadata.ts

@@ -10,26 +10,10 @@ export class DeleteVersionMetadataPathParams {
   MetaValue: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(
-    ApiId: string,
-    MetaKey: string,
-    MetaValue: string,
-    VersionId: string
-  ) {
-    this.ApiId = ApiId;
-    this.MetaKey = MetaKey;
-    this.MetaValue = MetaValue;
-    this.VersionId = VersionId;
-  }
 }
 
 export class DeleteVersionMetadataRequest {
   PathParams: DeleteVersionMetadataPathParams;
-
-  constructor(PathParams: DeleteVersionMetadataPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class DeleteVersionMetadataResponse {
@@ -38,10 +22,4 @@ export class DeleteVersionMetadataResponse {
   Error?: shared.Error;
 
   StatusCode: number;
-
-  constructor(ContentType: string, StatusCode: number, Error?: shared.Error) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/downloadschema.ts

@@ -6,19 +6,10 @@ export class DownloadSchemaPathParams {
   ApiId: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiId: string, VersionId: string) {
-    this.ApiId = ApiId;
-    this.VersionId = VersionId;
-  }
 }
 
 export class DownloadSchemaRequest {
   PathParams: DownloadSchemaPathParams;
-
-  constructor(PathParams: DownloadSchemaPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class DownloadSchemaResponse {
@@ -29,16 +20,4 @@ export class DownloadSchemaResponse {
   Schema?: string;
 
   StatusCode: number;
-
-  constructor(
-    ContentType: string,
-    StatusCode: number,
-    Error?: shared.Error,
-    Schema?: string
-  ) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.Schema = Schema;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/downloadschemarevision.ts

@@ -8,20 +8,10 @@ export class DownloadSchemaRevisionPathParams {
   RevisionId: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiId: string, RevisionId: string, VersionId: string) {
-    this.ApiId = ApiId;
-    this.RevisionId = RevisionId;
-    this.VersionId = VersionId;
-  }
 }
 
 export class DownloadSchemaRevisionRequest {
   PathParams: DownloadSchemaRevisionPathParams;
-
-  constructor(PathParams: DownloadSchemaRevisionPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class DownloadSchemaRevisionResponse {
@@ -32,16 +22,4 @@ export class DownloadSchemaRevisionResponse {
   Schema?: string;
 
   StatusCode: number;
-
-  constructor(
-    ContentType: string,
-    StatusCode: number,
-    Error?: shared.Error,
-    Schema?: string
-  ) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.Schema = Schema;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/findapiendpoint.ts

@@ -8,20 +8,10 @@ export class FindApiEndpointPathParams {
   DisplayName: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiId: string, DisplayName: string, VersionId: string) {
-    this.ApiId = ApiId;
-    this.DisplayName = DisplayName;
-    this.VersionId = VersionId;
-  }
 }
 
 export class FindApiEndpointRequest {
   PathParams: FindApiEndpointPathParams;
-
-  constructor(PathParams: FindApiEndpointPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class FindApiEndpointResponse {
@@ -32,16 +22,4 @@ export class FindApiEndpointResponse {
   Error?: shared.Error;
 
   StatusCode: number;
-
-  constructor(
-    ContentType: string,
-    StatusCode: number,
-    ApiEndpoint?: shared.ApiEndpoint,
-    Error?: shared.Error
-  ) {
-    this.ApiEndpoint = ApiEndpoint;
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.StatusCode = StatusCode;
-  }
 }

src/sdk/models/operations/generateopenapispec.ts

@@ -6,19 +6,10 @@ export class GenerateOpenApiSpecPathParams {
   ApiId: string;
   @Metadata("pathParam, style=simple;explode=false;name=versionID")
   VersionId: string;
-
-  constructor(ApiId: string, VersionId: string) {
-    this.ApiId = ApiId;
-    this.VersionId = VersionId;
-  }
 }
 
 export class GenerateOpenApiSpecRequest {
   PathParams: GenerateOpenApiSpecPathParams;
-
-  constructor(PathParams: GenerateOpenApiSpecPathParams) {
-    this.PathParams = PathParams;
-  }
 }
 
 export class GenerateOpenApiSpecResponse {
@@ -29,16 +20,4 @@ export class GenerateOpenApiSpecResponse {
   GenerateOpenApiSpecDiff?: shared.GenerateOpenApiSpecDiff;
 
   StatusCode: number;
-
-  constructor(
-    ContentType: string,
-    StatusCode: number,
-    Error?: shared.Error,
-    GenerateOpenApiSpecDiff?: shared.GenerateOpenApiSpecDiff
-  ) {
-    this.ContentType = ContentType;
-    this.Error = Error;
-    this.GenerateOpenApiSpecDiff = GenerateOpenApiSpecDiff;
-    this.StatusCode = StatusCode;
-  }
 }