feat: Improvements to dependents workflow (#1631)

- Dependents will now see their `out.openapi.yaml` files updated to
reflected the input spec
- Dependents can now be run from anywhere in the project

Author: chase-crumbaugh

cmd/run.go

@@ -255,11 +255,6 @@ func preRun(cmd *cobra.Command, flags *RunFlags) error {
 		flags.Target = targets[0]
 	}
 
-	// Needed later
-	if err := cmd.Flags().Set("target", flags.Target); err != nil {
-		return err
-	}
-
 	// Dependent only allows a single source for now
 	if flags.Dependent != "" {
 		if len(sources) == 1 {
@@ -276,6 +271,17 @@ func preRun(cmd *cobra.Command, flags *RunFlags) error {
 		}
 	}
 
+	// We must set these after prompting for them or else the user will be prompted a second time
+	if err := cmd.Flags().Set("source", flags.Source); err != nil {
+		return err
+	}
+	if err := cmd.Flags().Set("target", flags.Target); err != nil {
+		return err
+	}
+	if err := cmd.Flags().Set("dependent", flags.Dependent); err != nil {
+		return err
+	}
+
 	// Gets a proper value for a mapFlag based on the singleFlag value and the mapFlag value
 	// Helps ensure that the mapFlag ends up with a value for all the targets being run
 	checkAndGetMapFlagValue := func(flagName, singleFlag string, mapFlag map[string]string, validLangs []string) (map[string]string, error) {

internal/run/dependent.go

@@ -29,7 +29,7 @@ func RunDependent(ctx context.Context, source, dependent string, flagsString str
 		return fmt.Errorf("source must be specified")
 	}
 
-	wf, _, err := utils.GetWorkflowAndDir()
+	wf, projectDir, err := utils.GetWorkflowAndDir()
 	if err != nil {
 		return err
 	}
@@ -45,7 +45,8 @@ func RunDependent(ctx context.Context, source, dependent string, flagsString str
 		return fmt.Errorf("failed to build source %s: %w", source, err)
 	}
 
-	sourceLocation, err := filepath.Abs(*wf.Sources[source].Output)
+	sourceLocation := filepath.Join(projectDir, *wf.Sources[source].Output)
+	sourceLocation, err = filepath.Abs(sourceLocation)
 	if err != nil {
 		return fmt.Errorf("failed to get absolute path for source output: %w", err)
 	}
@@ -64,22 +65,25 @@ func RunDependent(ctx context.Context, source, dependent string, flagsString str
 
 		log.From(ctx).Infof("\n\n=== Rebuilding SDK %s ===\n", dependent)
 
-		if err := processDependent(ctx, dependent, r, flagsString, sourceLocation); err != nil {
+		if err := processDependent(ctx, dependent, r, flagsString, sourceLocation, projectDir); err != nil {
 			return fmt.Errorf("failed to process dependent %s: %w", dependent, err)
 		}
 	}
 
 	return nil
 }
 
-func processDependent(ctx context.Context, dependentName string, dependent workflow.Dependent, flagsString string, sourceLocation string) error {
+func processDependent(ctx context.Context, dependentName string, dependent workflow.Dependent, flagsString string, sourceLocation string, projectDir string) error {
 	logger := log.From(ctx)
 
 	location := dependent.Location
 	if location == "" {
 		return fmt.Errorf("dependent %s has no location specified", dependentName)
 	}
 
+	// Resolve location relative to projectDir
+	location = filepath.Join(projectDir, location)
+
 	// Check if location exists
 	if _, err := os.Stat(location); os.IsNotExist(err) {
 		cloneCommand := dependent.CloneCommand

internal/run/source.go

@@ -168,7 +168,8 @@ func (w *Workflow) RunSource(ctx context.Context, parentStep *workflowTracking.W
 		}
 	}
 
-	if !frozenSource {
+	// Must not be frozen source check! We DO want to write for source overrides
+	if !w.FrozenWorkflowLock {
 		if err := writeToOutputLocation(ctx, currentDocument, outputLocation); err != nil {
 			return "", nil, fmt.Errorf("failed to write to output location: %w %s", err, outputLocation)
 		}