enable and fix additional clippy lints

Author: spearman

.githooks/pre-commit

@@ -3,6 +3,6 @@
 set -e
 set -x
 
-cargo check --all-features
+cargo check --all-targets --all-features
 
 exit 0

.githooks/pre-push

@@ -7,8 +7,9 @@ if rg "FIXME"; then
   echo "pre-push hook failed: FIXME not allowed"
   exit 1
 fi
+cargo udeps --all-targets --all-features
 export RUSTFLAGS="-D warnings"
-cargo clippy --all-features
+cargo clippy --all-targets --all-features
 cargo test --all-features
 yamllint --no-warnings .github/workflows/ci.yml
 

Cargo.toml

@@ -19,3 +19,137 @@ rand_xorshift = "0.4.*"
 
 [features]
 derive_serdes = ["serde", "smallvec/serde"]
+
+[lints.clippy]
+allow-attributes = "warn"
+assertions-on-result-states = "warn"
+bool-to-int-with-if = "warn"
+branches-sharing-code = "warn"
+cast-possible-truncation = "warn"
+cast-possible-wrap = "warn"
+cast-sign-loss = "warn"
+checked-conversions = "warn"
+clear-with-drain = "warn"
+cloned-instead-of-copied = "warn"
+collection-is-never-read = "warn"
+debug-assert-with-mut-call = "warn"
+derive-partial-eq-without-eq = "warn"
+doc-broken-link = "warn"
+doc-include-without-cfg = "warn"
+doc-link-code = "warn"
+doc-link-with-quotes = "warn"
+doc-markdown = "warn"
+elidable-lifetime-names = "warn"
+empty-drop = "warn"
+empty-enum-variants-with-brackets = "warn"
+empty-structs-with-brackets = "warn"
+equatable-if-let = "warn"
+error-impl-error = "warn"
+explicit-deref-methods = "warn"
+filter-map-next = "warn"
+flat-map-option = "warn"
+format-collect = "warn"
+format-push-string = "warn"
+ignored-unit-patterns = "warn"
+impl-trait-in-params = "warn"
+implicit-clone = "warn"
+inefficient-to-string = "warn"
+infinite-loop = "warn"
+invalid-upcast-comparisons = "warn"
+iter-filter-is-ok = "warn"
+iter-filter-is-some = "warn"
+iter-with-drain = "warn"
+large-stack-frames = "warn"
+large-types-passed-by-value = "warn"
+literal-string-with-formatting-args = "warn"
+lossy-float-literal = "warn"
+macro-use-imports = "warn"
+manual-assert = "warn"
+manual-is-power-of-two = "warn"
+manual-is-variant-and = "warn"
+manual-let-else = "warn"
+map-unwrap-or = "warn"
+map-with-unused-argument-over-ranges = "warn"
+match-same-arms = "warn"
+match-wildcard-for-single-variants = "warn"
+maybe-infinite-iter = "warn"
+mem-forget = "warn"
+mismatching-type-param-order = "warn"
+missing-asserts-for-indexing = "warn"
+missing-const-for-fn = "warn"
+missing-panics-doc = "warn"
+module-name-repetitions = "warn"
+multiple-crate-versions = "warn"
+mut-mut = "warn"
+mutex-atomic = "warn"
+naive-bytecount = "warn"
+needless-bitwise-bool = "warn"
+needless-collect = "warn"
+needless-continue = "warn"
+needless-for-each = "warn"
+needless-pass-by-ref-mut = "warn"
+needless-pass-by-value = "warn"
+needless-raw-string-hashes = "warn"
+needless-raw-strings = "warn"
+no-effect-underscore-binding = "warn"
+non-std-lazy-statics = "warn"
+non-zero-suggestions = "warn"
+nonstandard-macro-braces = "warn"
+option-as-ref-cloned = "warn"
+precedence-bits = "warn"
+pub-underscore-fields = "warn"
+range-minus-one = "warn"
+range-plus-one = "warn"
+read-zero-byte-vec = "warn"
+redundant-clone = "warn"
+redundant-closure-for-method-calls = "warn"
+redundant-pub-crate = "warn"
+redundant-test-prefix = "warn"
+ref-as-ptr = "warn"
+ref-binding-to-reference = "warn"
+ref-option = "warn"
+ref-option-ref = "warn"
+ref-patterns = "warn"
+renamed-function-params = "warn"
+rest-pat-in-fully-bound-structs = "warn"
+same-functions-in-if-condition = "warn"
+same-name-method = "warn"
+set-contains-or-insert = "warn"
+significant-drop-in-scrutinee = "warn"
+significant-drop-tightening = "warn"
+single-char-pattern = "warn"
+single-option-map = "warn"
+str-split-at-newline = "warn"
+string-add-assign = "warn"
+suboptimal-flops = "warn"
+suspicious-operation-groupings = "warn"
+suspicious-xor-used-as-pow = "warn"
+trait-duplication-in-bounds = "warn"
+transmute-ptr-to-ptr = "warn"
+trivial-regex = "warn"
+trivially-copy-pass-by-ref = "warn"
+try-err = "warn"
+type-repetition-in-bounds = "warn"
+uninhabited-references = "warn"
+uninlined-format-args = "warn"
+unnecessary-debug-formatting = "warn"
+unnecessary-join = "warn"
+unnecessary-literal-bound = "warn"
+unnecessary-semicolon = "warn"
+unnecessary-struct-initialization = "warn"
+unnecessary-wraps = "warn"
+unneeded-field-pattern = "warn"
+unreadable-literal = "warn"
+unsafe-derive-deserialize = "warn"
+unused-async = "warn"
+unused-peekable = "warn"
+unused-result-ok = "warn"
+unused-rounding = "warn"
+unused-self = "warn"
+used-underscore-binding = "warn"
+used-underscore-items = "warn"
+useless-let-if-seq = "warn"
+verbose-bit-mask = "warn"
+verbose-file-reads = "warn"
+while-float = "warn"
+zero-sized-map-values = "warn"

examples/example.rs

@@ -7,23 +7,23 @@ fn main() {
   range_set::report_sizes();  // report some sizes of various range set types
 
   let mut s = RangeSet::<[RangeInclusive <u32>; 1]>::from (0..=2);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(!s.spilled());
 
   assert!(s.insert_range (8..=10).is_none());
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![0,1,2,8,9,10]);
 
   assert_eq!(s.insert_range (3..=12), Some (RangeSet::from (8..=10)));
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![0,1,2,3,4,5,6,7,8,9,10,11,12]);
 
   assert_eq!(s.remove_range (0..=2), Some (RangeSet::from (0..=2)));
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![3,4,5,6,7,8,9,10,11,12]);
@@ -35,54 +35,54 @@ fn main() {
   assert_eq!(v, vec![3,4,5,6,10,11,12]);
 
   assert_eq!(s.remove_range (6..=9), Some (RangeSet::from (6..=6)));
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![3,4,5,10,11,12]);
 
   assert_eq!(s.remove_range (5..=10),
     Some (RangeSet::from_valid_ranges (&[5..=5, 10..=10]).unwrap()));
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![3,4,11,12]);
 
   assert_eq!(s.remove_range (5..=20), Some (RangeSet::from (11..=12)));
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());   // stays spilled
   s.shrink_to_fit();      // manually un-spill
   assert!(!s.spilled());  // no longer spilled
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![3,4]);
 
   assert_eq!(s.remove_range (0..=10), Some (RangeSet::from (3..=4)));
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(!s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![]);
 
   let s = RangeSet::<[_; 4]>::from_ranges ([0..=3, 6..=10]);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   let s = range_set!(0..=3, 6..=10);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   println!("s.len(): {}", s.len());
   assert_eq!(s.len(), 9);
   let s = range_set!(0, 1, 2, 2, 3, 6, 7, 8, 8, 9, 10);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   let s = range_set![0..=(u32::MAX)];
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   let mut s = range_set![];
   s.insert_range(0..=u32::MAX);
   s.insert_range(0..=0);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   let mut s = range_set![];
   s.insert_range(0..=0);
   s.insert_range(0..=u32::MAX);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   let mut s = range_set![250..=(u8::MAX)];
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   s.remove_range (252..=253);
   s.remove_range (254..=254);
   s.remove_range (255..=255);
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
 }

examples/readme.rs

@@ -3,18 +3,18 @@ use range_set::{range_set, RangeSet};
 
 fn main() {
   let mut s = range_set![0..=2; 1];
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(!s.spilled());
 
   assert!(s.insert_range (8..=10).is_none());
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![0,1,2,8,9,10]);
 
   assert_eq!(s.insert_range (3..=12), Some (range_set![8..=10; 1]));
   s.shrink_to_fit();
-  println!("s: {:?}", s);
+  println!("s: {s:?}");
   assert!(!s.spilled());
   let v : Vec <u32> = s.iter().collect();
   assert_eq!(v, vec![0,1,2,3,4,5,6,7,8,9,10,11,12]);

shell.nix

@@ -1,6 +1,7 @@
 with import <nixpkgs> {};
 pkgs.mkShell {
   buildInputs = [
+    cargo-udeps
     rustup
     rust-analyzer
     yamllint